This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Merged
Conversation
dkbennett
approved these changes
Apr 9, 2024
krschau
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
The extension gives a false positive if a non-GitHub Url with 3 segments is put into the URL text box. This is because of the || condition. How the extension checks if the github URL is valid is
A bitbucket URL would give false positive because check 1 returns false and check 2 returns true. ||'s these together and the result is true.
Added an additional check to make sure the server can be probed.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
Manually ran.
Task: https://task.ms/49116620
PR checklist
Movies!
Before the fix!
After the fix!
