E536 Fix repository account selection with multiple accounts by dkbennett · Pull Request #354 · microsoft/devhomegithubextension · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Fix repository account selection with multiple accounts#354

Merged
dkbennett merged 1 commit intomainfrom
user/dkbennett/widgetdevidselection
Feb 22, 2024
Merged

Fix repository account selection with multiple accounts#354
dkbennett merged 1 commit intomainfrom
user/dkbennett/widgetdevidselection

Conversation

@dkbennett
Copy link
Member
@dkbennett dkbennett commented Feb 22, 2024

Summary of the pull request

This fixes widget configuration account selection when multiple accounts are present. This issue was found in recent bug bash. Previously, the first account in the list would be chosen, which may not have access to the repository. This has been changed to have the same logic as the data manager uses when finding which developer id has access to the selected repository (if any).

References and relevant issues

Closes #355

Detailed description of the pull request / Additional comments

  • Added new function in the RepositoryWidget base class to take a repository URL and discover which logged in account has access to that repository, and fetch that repository's information.
  • Updated the exception handling in the data manager to use same switch format as the new repository widget selection.

Validation steps performed

  • Verified mutiple accounts with separate private access to repositories is correctly selected and updated.
  • Verified the SAML error case for one repository is correctly handled and messaged to the user. This is when you have access but the organization prohibits the app from having access.

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@dkbennett dkbennett merged commit 6ee3460 into main Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Not found" Error When Pinning Issues Widget in Multi-User GitHub Scenario

3 participants

0