This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Merged
Conversation
AmelBawa-msft
approved these changes
Jan 26, 2024
| public void CredentialVault_CreateSingleton() | ||
| { | ||
| var credentialVault1 = new CredentialVault("DevHomeGitHubExtensionTest"); | ||
| Assert.IsNotNull(credentialVault1); |
Contributor
There was a problem hiding this comment.
nit: constructor won't return null
** all occurrences **
| var credentialVault2 = new CredentialVault("DevHomeGitHubExtensionTest"); | ||
| Assert.IsNotNull(credentialVault2); | ||
|
|
||
| Assert.AreNotEqual(credentialVault1, credentialVault2); |
Contributor
There was a problem hiding this comment.
The test name CreateSingleton hints that those two should be equal. Consider renaming the unit test or add comments.
| Assert.AreEqual(2, result.DeveloperIds.Count()); | ||
| Assert.AreNotEqual("dummytestuser1", result.DeveloperIds.First().LoginId); | ||
| Assert.AreNotEqual("dummytestuser1", result.DeveloperIds.Last().LoginId); | ||
| Assert.IsNotNull(new Uri(result.DeveloperIds.First().Url)); |
Contributor
There was a problem hiding this comment.
Consider using Assert.DoesNotThrow because Assert.IsNotNull will either pass or its argument will throw an exception.
EricJohnson327
approved these changes
Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Adding multiuser test and re-adding credential vault tests removed in #324
This is a test-only change.
References and relevant issues
#324
Detailed description of the pull request / Additional comments
Validation steps performed
Ran tests locally
PR checklist