8000 Teams tenantId correction by tracyboehrer · Pull Request #959 · microsoft/botbuilder-python · GitHub
[go: up one dir, main page]
Skip to content

Teams tenantId correction #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Teams tenantId correction #959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/botbuilder-core/botbuilder/core/bot_framework_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ async def create_conversation(
if reference.conversation and reference.conversation.tenant_id:
# Putting tenant_id in channel_data is a temporary while we wait for the Teams API to be updated
parameters.channel_data = {
"tenant": {"id": reference.conversation.tenant_id}
"tenant": {"tenantId": reference.conversation.tenant_id}
}

# Permanent solution is to put tenant_id in parameters.tenant_id
Expand Down
2 changes: 1 addition & 1 deletion libraries/botbuilder-core/tests/test_bot_framework_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ async def aux_func_assert_valid_conversation(context):
"request has invalid tenant_id on conversation",
)
self.assertEqual(
context.activity.channel_data["tenant"]["id"],
context.activity.channel_data["tenant"]["tenantId"],
tenant_id,
"request has invalid tenant_id in channel_data",
)
Expand Down
0