8000 Convert functional test pipeline to using key vault secrets by BruceHaley · Pull Request #865 · microsoft/botbuilder-python · GitHub
[go: up one dir, main page]

Skip to content
8000

Convert functional test pipeline to using key vault secrets #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Merged
merged 2 commits into from
Mar 16, 2020

Conversation

BruceHaley
Copy link
Contributor

Convert to key vault vars, relocate .yml files

@BruceHaley BruceHaley requested a review from axelsrz March 16, 2020 19:26

#StartupCommand: 'flask run --host=0.0.0.0 --port=3978'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really a minor thing (you can ignore it if you want) but would you consider adding a break line here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. New line added at EOF. Thanks.

@BruceHaley BruceHaley merged commit 01fcbe9 into master Mar 16, 2020
@BruceHaley BruceHaley deleted the v-bruhal/vars2keyvault3-16 branch March 16, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0