8000 Johtaylo/fix bld by johnataylor · Pull Request #84 · microsoft/botbuilder-python · GitHub
[go: up one dir, main page]
Skip to content

Johtaylo/fix bld #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2018
Merged

Johtaylo/fix bld #84

merged 3 commits into from
Jun 18, 2018

Conversation

johnataylor
Copy link
Member

No description provided.

@johnataylor johnataylor requested a review from stevengum June 16, 2018 01:00
@johnataylor
Copy link
Member Author

This doesn't fix the problems... quick summary of where we're at with this...
We have in the past checked in generated code - we think that is incompatible with the latest rev of the autorest runtime. We are investigating. We wanted to use the later revs of the autorest code only because it got us the async build of the client stubs. We are re-evaluating all this.

@daveta daveta self-requested a review June 18, 2018 17:52
@johnataylor johnataylor merged commit ec47b07 into master Jun 18, 2018
@johnataylor johnataylor deleted the johtaylo/fix-bld branch June 18, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@daveta daveta Awaiting requested review from daveta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnataylor @stevengum
0