8000 add Console-EchoBot sample by stevengum · Pull Request #83 · microsoft/botbuilder-python · GitHub
[go: up one dir, main page]

Skip to content

add Console-EchoBot sample #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2018
Merged

add Console-EchoBot sample #83

merged 2 commits into from
Jun 11, 2018

Conversation

stevengum
Copy link
Member
@stevengum stevengum commented Jun 8, 2018
  • Also expose botbuilder-schema in botbuilder-core Took this out.

@stevengum stevengum self-assigned this Jun 8, 2018
@stevengum stevengum requested review from johnataylor and daveta June 8, 2018 21:44
from botbuilder.schema import *
import botbuilder.schema

__all__ = [class_name for class_name in dir(botbuilder.schema) if class_name[0].isupper()]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you have to do this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...because I noticed this is not the same as the .NET though similar to the JavaScript.
i think for now we should track the C# when it comes to this type of thing
(though it looks like we have other issues in the c#)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed we'll stop mirroring botbuilder-js for this point; botframework-schema's exposure in botbuilder-core and therefore botbuilder was just a convenience item, so that people don't have to import multiple packages manually to use everything available in the upper-level packages (botbuilder* vs botframework-schema and botframework-connector).

Going forward we can follow the js pattern if people think its convenience is greater than having to keep track of all packages they need to import.

@stevengum stevengum merged commit c74d2b0 into master Jun 11, 2018
@stevengum stevengum deleted the v-stgum/consoleAdapter branch June 11, 2018 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0