8000 Support originating audience for skills conversations by EricDahlvang · Pull Request #821 · microsoft/botbuilder-python · GitHub
[go: up one dir, main page]
Skip to content

Support originating audience for skills conversations #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 4, 2020
Merged

Support originating audience for skills conversations #821

merged 6 commits into from
Mar 4, 2020

Conversation

EricDahlvang
Copy link
Member
@EricDahlvang EricDahlvang commented Mar 4, 2020 •
edited
Loading

Fixes #798
Fixes #799
Fixes #800
Fixes #553

ConversationIdFactoryBase is backwards compatible, and will work with legacy implementations as well as those which support SkillConversationIdFactoryOptions (see attached .zip for a legacy implementation, and new implementations of SkillConversationIdFactory and SkillHttpClient)

Incidentally, I noticed the Python sdk does not have an implement of SkillHttpClient, while javascript and dotnet do. Added a comment to #553 regarding this.

skill_factories_and_clients.zip

@tracyboehrer
Copy link
Member
  1. I can't reliably attest that these are the appropriate Skills changes so I just compared against C#
  2. Kudos on the ConversationIdFactoryBase method overload handling. This is pretty much how Axel recommended handling this. Use a Union or optional args and document in comments.
  3. C# has the SkillConversationIdFactory in each bot (sample). It's in BotBuilder.core in Python. I don't understand the arguments for one vs the other. Just a noted difference. Though I see why you did it.
  4. SkillConversationIdFactoryOptions: Axel has commented before on using @Property instead of normal class member vars. If your intention was to make them read-only (which doesn't really exist in Python since the caller can use the "protected" var) then OK. But it doesn't appear that C# provides read-only members. So I would just go with normal Python fields. self.from_bot_auth_scope, et.c..
  5. SkillConversationReference: Same as Sample code snippets #4

@EricDahlvang
Copy link
Member Author

Thank you @tracyboehrer ! I'll address these things, and tests, today. Before merging this, we should also determine what we are going to do about the SkillConversationIdFactory and missing SkillHttpClient. I'll bring this up in standup today.

@EricDahlvang EricDahlvang marked this pull request as ready for review March 4, 2020 20:08
@tracyboehrer tracyboehrer merged commit e141d08 into master Mar 4, 2020
@tracyboehrer tracyboehrer deleted the eric/addAudienceToSkills branch March 4, 2020 20:32
@ceciliaavila ceciliaavila mentioned this pull request May 27, 2021
Merged
@MartinLuccanera MartinLuccanera mentioned this pull request May 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

7466 @axelsrz axelsrz Awaiting requested review from axelsrz

@johnataylor johnataylor Awaiting requested review from johnataylor

@stevengum stevengum Awaiting requested review from stevengum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@EricDahlvang @tracyboehrer
0