8000 Sample 45 - Changed greeting to include instructions to type anything to see state by Zerryth · Pull Request #307 · microsoft/botbuilder-python · GitHub
[go: up one dir, main page]

Skip to content

Sample 45 - Changed greeting to include instructions to type anything to see state #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2019

Conversation

Zerryth
Copy link
Contributor
@Zerryth Zerryth commented Aug 22, 2019

Fixes #306


Added "To see conversation data, type anything." in 45.state-management/bots/state_management_bot.py for parity with C# sample as the "golden standard" sample.

@Zerryth Zerryth changed the title Changed greeting to include instructions to type anything to see state. Sample 45 - Changed greeting to include instructions to type anything to see state Aug 22, 2019
@Zerryth
Copy link
Contributor Author
Zerryth commented Aug 28, 2019

@axelsrz hmm...could you check to see why pytest is failing? I've only changed the text of a string in a sample...

@Zerryth
Copy link
Contributor Author
Zerryth commented Aug 29, 2019

image

Not quite sure why that would be failing now

@Zerryth Zerryth merged commit 63ebf22 into master Aug 29, 2019
@Zerryth Zerryth deleted the Zerryth/MinorInstructionsSample45 branch August 29, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor differences in what's displayed after user response 45.state-management bot
2 participants
0