8000 QnA Parity: Adding Active Learning Feature by Zerryth · Pull Request #264 · microsoft/botbuilder-python · GitHub
[go: up one dir, main page]
Skip to content

QnA Parity: Adding Active Learning Feature #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Aug 1, 2019
Merged

QnA Parity: Adding Active Learning Feature #264

merged 29 commits into from
Aug 1, 2019

Conversation

Zerryth
Copy link
Contributor
@Zerryth Zerryth commented Jul 18, 2019 •
edited
Loading

Fixes #241

Porting new QnA Maker feature, Active Learning, that was just introduced to C#/JS repos in 4.5, into Python

Adds:

Models:

  • FeedbackRecord
  • GenerateAnswerRequestBody
  • Metadata
  • QnAMakerTraceInfo
  • QueryResult
  • QueryResults
  • TrainRequestBody

Utils:

  • ActiveLearningUtils
  • GenerateAnswerUtils
  • HttpRequestUtils
  • QnATelemetryConstants
  • TrainUtils

Zerryth added 26 commits July 18, 2019 14:38
@Zerryth
Initial active learning commit w/FeedbackRecord model
c4dea4f
@Zerryth
port FeedbackRecords & added param types to FeedbackRecord
ecf797f
@Zerryth
added all qna models
77ec785
@Zerryth
begin porting HttpRequestUtils
8b74b2b
@Zerryth
ported GenerateAnswerUtils
f0b8839
@Zerryth
Merge branch 'master' of https://github.com/microsoft/botbuilder-python…
149a101 
… into Zerryth/ActiveLearning
@Zerryth
used black to auto format qna library
fa28650
@Zerryth
ported TrainUtils
c0a08d2
@Zerryth
TrainUtil now calls Train API in call_train()
8978af5
@Zerryth
resolved conflicts in qna imports
fbdc409
@Zerryth
black to format all libraries
449fa83
@Zerryth
ported ActiveLearningUtils class
36fbc34
@Zerryth
Merge branch 'master' into Zerryth/ActiveLearning
912feaa
@Zerryth
Ported all QnAMaker methods; reorganized folder structure according t…
2544638 
…o dotnet QnA update
@Zerryth
resolved conflicts
30b1fd8
@Zerryth
resolved conflicts AND SAVED CHANGES this time
9c3a148
@Zerryth
merge conflicts 3
3670a3c
@Zerryth
conflicts 4
8346dc0
@Zerryth
fixed linting errors
a70f672
@Zerryth
black to format
91e71f7
@Zerryth
made QnA classes serializable using msrest
d10f532
@Zerryth
changed class name to GenerateAnswerRequestBody to be consistent with…
0b78e1f 
… TrainRequestBody
@Zerryth
updated GenerateAnswerRequestBody's to document params correctly
5146812
@Zerryth
Merge branch 'master' of https://github.com/microsoft/botbuilder-python…
2b2939a 
… into Zerryth/ActiveLearning
@Zerryth
added call train api test case
2603f14
@Zerryth
completed tests for low score variation
d71abb6
@Zerryth Zerryth marked this pull request as ready for review July 31, 2019 23:22
@Zerryth Zerryth requested a review from axelsrz July 31, 2019 23:22
gurvsing
gurvsing suggested changes Aug 1, 2019
View reviewed changes
@gurvsing
Copy link
Contributor
gurvsing commented Aug 1, 2019

Thanks for the PR.

axelsrz
axelsrz approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member
@axelsrz axelsrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Just a small question about a comment, but otherwise :shipit:

@Zerryth Zerryth merged commit 1f541e4 into master Aug 1, 2019
@Zerryth Zerryth deleted the Zerryth/ActiveLearning branch August 1, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurvsing gurvsing gurvsing approved these changes

@axelsrz axelsrz axelsrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Active Learning Support for QnA (Repo Parity)
3 participants
@Zerryth @gurvsing @axelsrz
0