8000 OAuthPrompt was constructing InvokeResponse incorrectly in some cases. by tracyboehrer · Pull Request #1798 · microsoft/botbuilder-python · GitHub
[go: up one dir, main page]

Skip to content

OAuthPrompt was constructing InvokeResponse incorrectly in some cases. #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

tracyboehrer
Copy link
Member

Fixes #1797

@axelsrz axelsrz merged commit 7d7fa53 into main Nov 3, 2021
@axelsrz axelsrz deleted the tracyboehrer/oauth_prompt_invokeresponse branch November 3, 2021 16:53
@maheshpardeshi
Copy link

This change in Pythons oauth_prompt file now when we are deploying app file to azure teams service how to do change in OAuth file of azure virtual env. Do we have to go with a specific version of Python or what

@Wajeed-msft
Copy link

@axelsrz , @tracyboehrer - Could you please share the SDK version from which this change is avaialble?

@tracyboehrer
Copy link
Member Author

@maheshpardeshi and @Wajeed-msft, We will release a 4.14.1 patch shortly.

@maheshpardeshi
Copy link
maheshpardeshi commented Dec 29, 2021

Hello Team, till when 4.14.1 will get released. We are waiting for this and our solution is not working on the production.

tracyboehrer added a commit that referenced this pull request Jan 4, 2022
* OAuthPrompt was constructing InvokeResponse incorrectly in some cases. (#1798)

Co-authored-by: Axel Suárez <axsuarez@microsoft.com>

* Bump to 4.14.1

Co-authored-by: Axel Suárez <axsuarez@microsoft.com>
tracyboehrer added a commit that referenced this pull request Jan 4, 2022
#1798) (#1845)

Co-authored-by: Axel Suárez <axsuarez@microsoft.com>

Co-authored-by: Axel Suárez <axsuarez@microsoft.com>
tracyboehrer added a commit that referenced this pull request Jan 4, 2022
* OAuthPrompt was constructing InvokeResponse incorrectly in some cases. (#1798)

Co-authored-by: Axel Suárez <axsuarez@microsoft.com>

* Delete app ids, pws. (#1802)

* Delete app ids, pws.

* Comment out broken tests.

* Comment out the final failing test.

* Formatted for Black compliance

* lint fixes

* Another black-compliance fix.

Co-authored-by: Axel Suárez <axsuarez@microsoft.com>
Co-authored-by: BruceHaley <v-brucehaley@microsoft.com>
@tracyboehrer
Copy link
Member Author

@maheshpardeshi Apologies for the delay. 4.14.1 should be live on PyPi now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In bot builder dialog after successful login, login_step function is not getting called.
4 participants
0