Fix get_conversation_reference in skill_handler_impl #1765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelsrz
approved these changes
Jul 6, 2021
axelsrz
pushed a commit
that referenced
this pull request
Jul 7, 2021
Co-authored-by: Santiago Grangetto <38112957+santgr11@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
This PR adds a validation in
_skill_handler_impl.pyfor theget_skill_conversation_referencemethod.This missing validation was causing an error in bots with a custom
SkillConversationIdFactoryclass, building the reference in theget_conversation_referencemethod, and being over nested.This fix was introduced in PR #1728 and lost with the migration from
skill_handler.pyto_skill_handler_impl.pyin PR #1707With the change in this PR, the users can still use their previous implementation of the
SkillConversationIdFactory.The bots used to test are the WaterfallHostBot Python and WaterfallSkillBot Python from the BotFramework-FunctionalTests repo.
The BotBuilder version used for all the packages is the most recent as of today from the main branch of this repo.
Specific Changes
Testing
Before the change the Host Bot throws the following errors in the step shown, using the current latest version of main from botbuilder-core.
After applying the changes in this PR, the conversation works as expected.
