8000 serialization: py json interop by congysu · Pull Request #153 · microsoft/botbuilder-python · GitHub
[go: up one dir, main page]
Skip to content

serialization: py json interop #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 2, 2019
Merged

serialization: py json interop #153

merged 3 commits into from
May 2, 2019

Conversation

congysu
Copy link
Member
@congysu congysu commented May 1, 2019
  • serialize for RecognizerResult, LuisResult etc.
  • add test for telemetry
  • add test for trace activity

@congysu
serialization: py json interop
f567a9c 
* serialize for RecognizerResult, LuisResult etc.
* add test for telemetry
* add test for trace activity
@congysu congysu requested review from axelsrz and daveta May 1, 2019 17:52
daveta
daveta reviewed May 1, 2019
View reviewed changes
libraries/botbuilder-ai/botbuilder/ai/luis/luis_prediction_options.py
timeout: float = 100000,
telemetry_client: BotTelemetryClient = NullTelemetryClient,
log_personal_information: bool = False,
):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How "to the letter of the law" are we going to be following C#? I like this as a usability feature.
https://github.com/Microsoft/botbuilder-dotnet/blob/master/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisPredictionOptions.cs

daveta
daveta approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor
@daveta daveta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

congysu and others added 2 commits May 9E4F 1, 2019 16:17
@congysu
add more tests
ee138a0 
* add more telemetry tests
* add more json tests
@axelsrz
Merge branch 'master' into cysu/recog
d92de1a
@axelsrz axelsrz merged commit c56d828 into master May 2, 2019
@axelsrz axelsrz deleted the cysu/recog branch May 2, 2019 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveta daveta daveta approved these changes

@axelsrz axelsrz Awaiting requested review from axelsrz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congysu @daveta @axelsrz
0