8000 Feature parity with C# and JS by Zerryth · Pull Request #148 · microsoft/botbuilder-python · GitHub
[go: up one dir, main page]
Skip to content

Feature parity with C# and JS #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 87 commits into from
Apr 29, 2019
Merged

Feature parity with C# and JS #148

merged 87 commits into from
Apr 29, 2019

Conversation

Zerryth
Copy link
Contributor
@Zerryth Zerryth commented Apr 26, 2019 •
edited
Loading
  • QnAMaker class with basic features implemented

working on:

  • telemetry
  • tests
  • nice things like throwing errors

axelsrz and others added 30 commits April 11, 2019 22:03
@axelsrz
adding base of activity handler, addition to a sample pending
78c6751
initial file structure (empty class files)
818e811
@daveta
SAFEKEEPING Checkin to unblock congysu
aa3a072
@congysu
port for dialog instance
03f5a75
@daveta
Add unittest test, fix setup.py, misc stubs to get initial test running
4a5afc2
@daveta
Merge branch 'work-in-progress' of https://github.com/Microsoft/botbu…
58c9468 
…ilder-python into work-in-progress
@daveta
Make dialog_set test work
f30ec6d
@daveta
Add PropertyManager
e83a392
@congysu
Port channel for choices and channels for connector
1420622 
* add docstring with google/pytorch style
* add initial test with unittest
8000 @daveta
Add WaterfallDialog initial checkin
814cbf9
@daveta
Base prompt stuff
478c4ed
@daveta
Miss a few files
cb434bd
@daveta
fix package spelling!
3d01cb1
@daveta
Target Python 3.6 - remove reference to PEP which does not exist
aa43ad2
@daveta
Add aiounittest as formal dependency (in setup.py)
20571b0
@congysu
Port ChoiceFactoryOptions
bb78153
@daveta
Fix 3.6-specific issues
6229bdb
@congysu
Add Choice
918cb37
@daveta
Confirm prompt safe keeping
4e732cc
@daveta
Initial DateTimePrompt
e40da60
@daveta
First Number Prompt test, fix a bunch of issues
6a85978
@congysu
Add ChoiceFactory
798b616
@congysu
add unittest for choice factory
c522b72 
* update ChoiceFactory etc.
* update casing for Channels, and others.
@daveta
Add component_dialog, fix tons of things
b88f8a9
@daveta
Fix memory_storage, remove tons of semicolons, other cleanup
71eb546
@daveta
Move pytest to unittest (or aiounittest as the case may be)
384c873
@daveta
Small fixes
61b56de
few tests for bot state
bd8344d
@daveta
Safekeeping checkin
7cc45e2
@daveta
Forgot a few files
0d0d14b
congysu and others added 18 commits April 27, 2019 16:17
@congysu
tests for list entity etc
f621b93 
* prebuilt entity with multiple values
* list entity with single value
* list entity with multiple values
@congysu
test for composite entity
1526bad
@congysu
add test for datetime entity
396691a 
* test for multiple datetime entities
* test for v1 datetime resolution
@congysu
add test for top intent
80fe1f0
@daveta
Support and sample for flask/django
a56b55f
@Zerryth
fixed spacing in files
e581ebd
@Zerryth
Merge branch 'work-in-progress' of https://github.com/Microsoft/botbu…
4271921 
…ilder-python into work-in-progress
@congysu
add user agent
395f95b 
* add user agent
* add test for user agent
@congysu
add connection timeout
f3cac96 
* add connection timeout
* add test for connection timeout
@Zerryth
ctor tests
00d0bd2
@Zerryth
Merge branch 'work-in-progress' of https://github.com/Microsoft/botbu…
158eac7 
…ilder-python into work-in-progress
@Zerryth
added mocks to test QnAMaker.get_answers()
59b5cbc
@Zerryth
test: returns answer w/o options
19762ce
@congysu
update comments for luis prediction options
39cd559 
and update tests
@axelsrz
build fixing, sync with appinsights needed
1a448d8
@axelsrz
Merge branch 'work-in-progress' of https://github.com/Microsoft/botbu…
5a6e3fe 
…ilder-python into work-in-progress

Merge.
@axelsrz
skipping tests with pending class
be23f75
@axelsrz
remove unnecessary ()
99a15a1
@stevengum
Copy link
Member

@daveta, @congysu, @axelsrz, @Zerryth Why is everyone working on the same branch and touching different libraries?

Reviewers who like to use Code Flow cannot use the tool to review this PR due to the number of commits. Please consider getting this PR in ASAP and then quickly iterating with separate PRs. Otherwise this PR is going to be close to impossible to review.

@Zerryth
Copy link
Contributor Author
Zerryth commented Apr 29, 2019

@stevengum I have a sneaking suspicion the reason is "b/c Ashley messed up with git/github at some point >_>"

@axelsrz
Copy link
Member
axelsrz commented Apr 29, 2019

@stevengum @Zerryth Actually what happened is that I was using this branch 3 weeks ago to push the general template for the new classes and my guess is that because a lot of breaking code was pushed in a small amount of time, this branch was used as quick push. We should start to at least make PRs against this branch (work-in-progress). I'm almost done with building the fix so we can do that from now on.

@Zerryth Zerryth requested a review from axelsrz April 29, 2019 23:05
@axelsrz axelsrz changed the title QnaMaker Basic Features Feature parity with C# and JS Apr 29, 2019
@axelsrz axelsrz merged commit 274663d into master Apr 29, 2019
@axelsrz axelsrz deleted the work-in-progress branch April 29, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelsrz axelsrz axelsrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zerryth @stevengum @axelsrz @daveta @congysu
0