8000 Allow skills with no appId or password by mdrichardson · Pull Request #1406 · microsoft/botbuilder-python · GitHub
[go: up one dir, main page]
Skip to content

Allow skills with no appId or password #1406

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 16, 2020
Merged

Allow skills with no appId or password #1406

merged 9 commits into from
Oct 16, 2020

Conversation

mdrichardson
Copy link
Contributor
@mdrichardson mdrichardson commented Oct 13, 2020 •
edited
Loading

Fixes #1396

  • Added new Skill constant to RoleTypes
  • Updated BotframeworkHttpCllient to set the Role in the Recipient of the outgoing activity clone to RoleTypes.Skill
  • Updated ChannelServiceHanlder to add an anonymous skill AppId claim when auth is disabled.
  • Updated AppCredentials.ShouldSetToken() logic to avoid sending a token when the AppId is not set or when it is set to the anonymous skill appId.
  • Updated SkillValidation.IsSkillClaim to return true for anonymous skills.
  • Updated JwtTokenValidation.AuthenticateRequest to check the Role property in the incoming activity to determine if the request is coming from another bot or the channel.
  • Added AuthenticationConstants.AnonymousSkillAppId constant.
  • Added AuthenticationConstants.AnonymousAuthType constant and updated related code to use it instead of using hardcoded "anonymous"
  • Added unit tests for new logic.

Testing

Try any skill sample from the emulator without using AppIds and Passwords

@mdrichardson mdrichardson marked this pull request as ready for review October 15, 2020 21:44
@axelsrz axelsrz merged commit a30301b into microsoft:main Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelsrz axelsrz axelsrz approved these changes

@tracyboehrer tracyboehrer Awaiting requested review from tracyboehrer

@gabog gabog Awaiting requested review from gabog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I can develop skills in Emulator without an app password (Python)
2 participants
@mdrichardson @axelsrz
0