8000 Cherry-Pick Skill Validation to 4.7 (#1375) by EricDahlvang · Pull Request #1379 · microsoft/botbuilder-python · GitHub
[go: up one dir, main page]

Skip to content

Cherry-Pick Skill Validation to 4.7 (#1375) #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2020

Conversation

EricDahlvang
Copy link
Member

No description provided.

Validation

* Throw if is_skill_claim and claims_validator is null

* Update jwt_token_validation.py
@axelsrz axelsrz self-requested a review September 4, 2020 03:04
@axelsrz axelsrz merged commit 5b53dd5 into 4.7 Sep 4, 2020
@axelsrz axelsrz deleted the eric/cherryPickSkillValidation4.7 branch September 4, 2020 19:13
@axelsrz
Copy link
Member
axelsrz commented Sep 4, 2020

This was force pushed due that only fails in 3.8 (not specifically supported at that time) and fails on tests that has nothing to do with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0