Support SSO with skill dialog and expected replies #1038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengum
reviewed
May 2, 2020
| token=TestAdapter.__EXCEPTION_EXPECTED, | ||
| ) | ||
|
|
||
| self.exchangeable_tokens[key.to_key()] = key |
There was a problem hiding this comment.
I noticed the same code in JavaScript; in JS you can use objects as keys Maps, so I might change the JS impl to do that (parity with C#).
I don't recall, but I believe there is something similar in Python...
Note, this isn't actionable for this PR, just potential future code cleanup.
EricDahlvang
reviewed
May 4, 2020
cleemullins
approved these changes
May 4, 2020
| ) | ||
|
|
||
| # Check response status: true if success, false if failure | ||
| return response.status / 100 == 2 |
There was a problem hiding this comment.
First time I see this, interesting. Is there no built in or popular function in python for this? i.e. dotnet has HttpStatusCodes and IsSuccessStatusCode() in a package that gets added everywhere anyways. If it requires adding a new package for this check, then it is not worth, but just checking.
carlosscastro
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #918
Port of microsoft/botbuilder-dotnet#3818