Update Components to address Component Governance issues #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- remove grunt-contrib-qunit
- update puppeteer
- remove grunt-contrib-qunit - update puppeteer
There was a problem hiding this comment.
Pull Request Overview
This PR addresses Component Governance issues by removing the deprecated grunt-contrib-qunit dependency and updating the Puppeteer dependency.
- Removed grunt-contrib-qunit from multiple package.json files and gruntfile.js.
- Updated Puppeteer to version 24.8.2 and added eventemitter2 as a new dependency.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/rollup-plugin-uglify3-js/package.json | Removed grunt-contrib-qunit from devDependencies |
| package.json | Removed grunt-contrib-qunit, updated Puppeteer, and added eventemitter2 |
| gruntfile.js | Removed grunt.loadNpmTasks call for grunt-contrib-qunit |
| common/Tests/Framework/package.json | Removed grunt-contrib-qunit from devDependencies |
hectorhdzg
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.