Update Components to address governance issues #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request updates several component versions to address governance issues. Key changes include version bumps for grunt-contrib-qunit, Rush, and Puppeteer, as well as minor code refactorings and grammar fixes in the install-run scripts.
- Updated dependency versions in package.json, tools/rollup-plugin-uglify3-js/package.json, and common/Tests/Framework/package.json.
- Updated Rush version in rush.json and package.json.
- Refactored external module imports and improved object merging in common/scripts/install-run.js and common/scripts/install-run-rush.js.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/rollup-plugin-uglify3-js/package.json | Bumped grunt-contrib-qunit version to ^6.2.1. |
| rush.json | Updated rushVersion from 5.148.0 to 5.153.1. |
| package.json | Updated @microsoft/rush, grunt-contrib-qunit, and Puppeteer versions. |
| common/scripts/install-run.js | Refactored _copyAndTrimNpmrcFile call with spread operator and fixed comment grammar. |
| common/scripts/install-run-rush.js | Reordered external module imports and fixed comment grammar. |
| common/Tests/Framework/package.json | Bumped grunt-contrib-qunit version to ^6.2.1. |
Comments suppressed due to low confidence (2)
common/scripts/install-run.js:209
- [nitpick] When merging options using the spread operator, ensure that explicitly set properties (like targetNpmrcPath) are not unintentionally overwritten by values in options. Consider validating the incoming options object or controlling property precedence if necessary.
targetNpmrcPath,
common/scripts/install-run-rush.js:35
- [nitpick] The reordering and redefinition of external modules (such as 'fs') may affect module resolution or caching behavior. Ensure that this change aligns with your bundler configuration and does not introduce side effects in how external dependencies are handled.
module.exports = require("fs");
Karlie-777
approved these changes
May 7, 2025
|
@microsoft-github-policy-service rerun |
1 similar comment
|
@microsoft-github-policy-service rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.