Info and error popup content copyable to clipboard #724
Conversation
|
OK, so - the snippets feels a bit controversial? I'm totally happy to get the copy button in, I copy this stuff all the time 👍 |
|
Brought the snippets back! Fortunately, there's an upcoming ST build that's going to let us ignore default snippets using an I also got the copy error functionality working again, it had broken because this PR was old and when I merged all the new commits into it there were a bunch of merge conflicts. The sooner we get it merged the better! |
|
Just bumping, because I think this is ready to merge =) |
|
I will take a look at this but I need to get back home to NYC from my vacation to test this (I broke the last sublime text update, so I want to at least get my dev env set up to validate master and PRs are working as expected) so thanks for the update! (and if you don't hear from me by next Friday, ping this PR) |
|
Just bumping to see if you can eyes on this and we can get it merged. Thank you! |
|
Alright, great timing on your ping. I got back yesterday and gave it a run through just now
Looks good to me 👍 |
|
Thanks a bunch!!! |
This PR contains two changes.
The first is a simple usability win; info and error popup content is copyable to the clipboard, via a popup link/button below the content.
HTML tags are stripped from the content. Line breaks and general formatting are conserved. When the user presses the copy link, a
status_messageis printed confirming the text was copied.This is the text copied to the clipboard:
The other change, which is not related to popup content at all, but which IMO is a big improvement as well, is getting rid of the snippets that are bundled with this plugin.
These snippets are all based on, or are identical to, the snippets that ship with Sublime Text's default JavaScript package, and which pretty much everyone agrees were a mistake.
Just to give one egregious example, the "improved" for loop:
There are some good comments in that thread, especially from @Thom1729 , regarding why bundling snippets with a package is a bad idea, even if said snippets aren't as wacky as the one above.
Maybe someone thought copying Sublime's default JS snippets to this package would be comforting for existing Sublime users, but it was copying a misfeature, and just creates noise and makes autocomplete less useful for everyone.
I'd be glad to separate this into its own PR if it's necessary, but it seems like such a clear usability win that I figured the sooner it gets merged the better.