8000 Check using "super" before "this" lexically by yuit · Pull Request #6860 · microsoft/TypeScript · GitHub
[go: up one dir, main page]
Skip to content

Check using "super" before "this" lexically #6860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 11, 2016
Merged

Check using "super" before "this" lexically #6860

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a5cf7c1
add conformance tests
Feb 3, 2016
76b6bff
Update baselines
Feb 3, 2016
ed09628
Check using "super" before "this" lexically instead of using the
Feb 2, 2016
7e1088b
Address PR
Feb 3, 2016
2dbc998
Address PR about tests
Feb 3, 2016
aff6775
Add a flag so we don't repeatedly finding super call
Feb 3, 2016
1d4c1d1
rename function
Feb 4, 2016
47a2f3b
Move tests into correct location
Feb 4, 2016
1cfce12
Merge branch 'release-1.8' into checksuperbeforethislexically
Feb 8, 2016
dc8e0cc
Address PR
Feb 8, 2016
61e954b
8000 Address PR: report error on super call instead of entire constructor …
Feb 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address PR about tests
  • Loading branch information
Kanchalai Tanglertsampan committed Feb 3, 2016
commit 2dbc998da4778fece33cbf0cb3ad4fb556d3b318
20 changes: 0 additions & 20 deletions tests/baselines/reference/superCallBeforeThisAccessing1.errors.txt
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions tests/baselines/reference/superCallBeforeThisAccessing1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
//// [superCallBeforeThisAccessing1.ts]
declare var Factory: any

class Base {
constructor(c) { }
}
Expand Down
38 changes: 38 additions & 0 deletions tests/baselines/reference/superCallBeforeThisAccessing1.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
=== tests/cases/conformance/classes/superCallBeforeThisAccessing1.ts ===
declare var Factory: any
>Factory : Symbol(Factory, Decl(superCallBeforeThisAccessing1.ts, 0, 11))

class Base {
>Base : Symbol(Base, Decl(superCallBeforeThisAccessing1.ts, 0, 24))

constructor(c) { }
>c : Symbol(c, Decl(superCallBeforeThisAccessing1.ts, 3, 16))
}
class D extends Base {
>D : Symbol(D, Decl(superCallBeforeThisAccessing1.ts, 4, 1))
>Base : Symbol(Base, Decl(superCallBeforeThisAccessing1.ts, 0, 24))

private _t;
>_t : Symbol(_t, Decl(superCallBeforeThisAccessing1.ts, 5, 22))

constructor() {
super(i);
>super : Symbol(Base, Decl(superCallBeforeThisAccessing1.ts, 0, 24))
>i : Symbol(i, Decl(superCallBeforeThisAccessing1.ts, 12, 11))

var s = {
>s : Symbol(s, Decl(superCallBeforeThisAccessing1.ts, 9, 11))

t: this._t
>t : Symbol(t, Decl(superCallBeforeThisAccessing1.ts, 9, 17))
>this._t : Symbol(_t, Decl(superCallBeforeThisAccessing1.ts, 5, 22))
>this : Symbol(D, Decl(superCallBeforeThisAccessing1.ts, 4, 1))
>_t : Symbol(_t, Decl(superCallBeforeThisAccessing1.ts, 5, 22))
}
var i = Factory.create(s);
>i : Symbol(i, Decl(superCallBeforeThisAccessing1.ts, 12, 11))
>Factory : Symbol(Factory, Decl(superCallBeforeThisAccessing1.ts, 0, 11))
>s : Symbol(s, Decl(superCallBeforeThisAccessing1.ts, 9, 11))
}
}

43 changes: 43 additions & 0 deletions tests/baselines/reference/superCallBeforeThisAccessing1.types
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
=== tests/cases/conformance/classes/superCallBeforeThisAccessing1.ts ===
declare var Factory: any
>Factory : any

class Base {
>Base : Base

constructor(c) { }
>c : any
}
class D extends Base {
>D : D
>Base : Base

private _t;
>_t : any

constructor() {
super(i);
>super(i) : void
>super : typeof Base
>i : any

var s = {
>s : { t: any; }
>{ t: this._t } : { t: any; }

t: this._t
>t : any
>this._t : any
>this : this
>_t : any
}
var i = Factory.create(s);
>i : any
>Factory.create(s) : any
>Factory.create : any
>Factory : any
>create : any
>s : { t: any; }
}
}

4 changes: 3 additions & 1 deletion tests/cases/conformance/classes/superCallBeforeThisAccessing1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
class Base {
declare var Factory: any

class Base {
constructor(c) { }
}
class D extends Base {
Expand Down
0