DOM update 2024-04-16 #58211
Merged
DOM update 2024-04-16 #58211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@typescript-bot test it |
Collaborator
Collaborator
|
@jakebailey Here are the results of running the user tests comparing Everything looks good! |
Collaborator
|
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Collaborator
|
@ja
8000
kebailey Here are the results of running the top 400 repos comparing Everything looks good! |
Member
Author
|
Requires slightly more memory presumably because it adds a few more types and properties. |
Member
|
@typescript-bot run dt |
Collaborator
Collaborator
|
Hey @jakebailey, the results of running the DT tests are ready. There were interesting changes: Branch only errors:Package: webrtc |
Member
|
Ah, webrtc, our old friend |
Member
Author
|
Yeah, that's expected, since types/webrtc is supposed to be a superset of whatever's in the DOM. I'll merge this tomorrow after I merge all the test baseline conflicts. Is this the result of the new performance stats? Or maybe it's the generated-type spans. |
Member
Both, probably. |
1 task
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 5.5 beta
[Symbol.asyncIterator]andvaluesAbortSignal.anymethodDocument.parseHTMLUnsafe,ShadowRoot.setHTMLUnsafe"select-one" | "select-multiple"instead ofstringLargestContentfulPaint