-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Compilation of Js Files #5345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Compilation of Js Files #5345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re is filename tag
…g js files compilation
…pecifying .ts file
…sent and tsconfig doesnt specify any filenames
…oesnt contain any name
…fig file specifying them
…fig file doesnt specifying any names
…rectory only if specified in the options
- Command line now takes --jsExtension multiple times or comma separated list of extensions - tsconfig accepts array of extension strings
…he declaration file in program has error
// Get first non javascript function declaration | ||
if (declaration.kind === node.kind && !isInJavaScriptFile(getSourceFile(declaration))) { | ||
return declaration; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explicitly return undefined?
@@ -2294,6 +2310,10 @@ | |||
"category": "Message", | |||
"code": 6072 | |||
}, | |||
"Specifies extensions to treat as javascript file. To specify multiple extensions, either use this option multiple times or provide comma separated list.": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"as JavaScript files."
"provide a comma separated list."
This was referenced Oct 30, 2015
This is now taken care of in #5471 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes same as #4826, just against javascriptModules branch instead of master
Compiler treats javascript files like declaration files and does not emit any output corresponding to them. Here are the list of work this PR supports: