8000 Tune FAR aggregation by amcasey · Pull Request #49581 · microsoft/TypeScript · GitHub
[go: up one dir, main page]
Skip to content

Tune FAR aggregation #49581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 16, 2022
Merged

Tune FAR aggregation #49581

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58a4aad
Tune FAR aggregation
amcasey Jun 16, 2022
f3a41fc
Add missing null-checks
amcasey Jun 16, 2022
a12e29e
Fix lint errors
amcasey Jun 16, 2022
7f1e10c
Remove redundant null checks and unreachable case
amcasey Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint errors
  • Loading branch information
@amcasey
amcasey committed Jun 16, 2022
commit a12e29ea585f70c6f6ed1fa2621602cf69509c89
7 changes: 3 additions & 4 deletions src/server/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ namespace ts.server {
// correct results to all other projects.

const defaultProjectResults = perProjectResults.get(defaultProject);
if (defaultProjectResults?.[0].references[0]?.isDefinition === undefined) {
if (defaultProjectResults?.[0]?.references[0]?.isDefinition === undefined) {
// Clear all isDefinition properties
perProjectResults.forEach(projectResults => {
if (projectResults) {
Expand Down Expand Up @@ -545,10 +545,9 @@ namespace ts.server {
if (cancellationToken.isCancellationRequested()) break onCancellation;

let skipCount = 0;
for (; skipCount < queue.length && resultsMap.has(queue[skipCount].project); skipCount++) {
}
for (; skipCount < queue.length && resultsMap.has(queue[skipCount].project); skipCount++);

if (skipCount == queue.length) {
if (skipCount === queue.length) {
queue.length = 0;
break;
}
Expand Down
0