8000 Add math intrinsic types by skeate · Pull Request #48198 · microsoft/TypeScript · GitHub
[go: up one dir, main page]
Skip to content

Add math intrinsic types #48198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skeate wants to merge 10 commits into from
+1,689 −64
Closed

Add math intrinsic types #48198

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6576198
Add math intrinsic types
skeate Jun 1, 2024
7ef54d9
Fixed name collision in `recursiveConditionalCrash4`
james-pre Mar 12, 2025
deeafac
Accept some new (correct) baselines
james-pre Mar 12, 2025
8000 ecec5e3
Ensure `Integer<T>` is `T` when `T` is `any`, `number`, or `bigint`
james-pre Mar 12, 2025
10664a3
Rename `Integer` -> `Floor`, for clarity
james-pre Mar 12, 2025
ec24b2b
Finished renaming `Integer` -> `Floor` (accept new baselines)
james-pre Mar 12, 2025
4299762
Reduce code duplication in `getIntrinsicMappingType`/2 and `applyNumb…
james-pre Mar 12, 2025
76eb8c0
Add `Ceil` and `Round` types
james-pre Mar 12, 2025
8b442e5
Formatting
james-pre Mar 12, 2025
dc82234
Merge pull request #2 from james-pre/math-types
skeate Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ensure Integer<T> is T when T is any, number, or bigint
  • Loading branch information
@james-pre
james-pre committed Mar 12, 2025
commit ecec5e38ca18e51772102c0303d1f18c9d51c676
5 changes: 3 additions & 2 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18392,6 +18392,8 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
// Mapping<Mapping<T>> === Mapping<T>
type.flags & TypeFlags.StringMapping && symbol === type.symbol ? type :
type.flags & TypeFlags.Calculation ? getCalculationTypeForGenericType(symbol, [type]) :
// Ensure Integer<T> === T when T is any, number, or bigint
intrinsicTypeKinds.get(symbol.escapedName as string) === IntrinsicTypeKind.Integer && (type.flags & (TypeFlags.Any | TypeFlags.Number | TypeFlags.BigInt)) ? type :
type.flags & (TypeFlags.Any | TypeFlags.String | TypeFlags.StringMapping) || isGenericIndexType(type) ? getStringMappingTypeForGenericType(symbol, type) :
// This handles Mapping<`${number}`> and Mapping<`${bigint}`>
isPatternLiteralPlaceholderType(type) ? getStringMappingTypeForGenericType(symbol, getTemplateLiteralType(["", ""], [type])) :
Expand Down Expand Up @@ -18804,8 +18806,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
}

function isGenericStringLikeType(type: Type) {
// @todo TypeFlags.Calculation not exactly stringlike right?
return !!(type.flags & (TypeFlags.TemplateLiteral | TypeFlags.StringMapping | TypeFlags.Calculation)) && !isPatternLiteralType(type);
return !!(type.flags & (TypeFlags.TemplateLiteral | TypeFlags.StringMapping)) && !isPatternLiteralType(type);
}

function isGenericType(type: Type): boolean {
Expand Down
0