Fix module resolution for import call emit #41390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
approved these changes
Dec 16, 2020
weswigham
reviewed
Dec 16, 2020
| const argument = visitNode(firstOrUndefined(node.arguments), moduleExpressionElementVisitor); | ||
| const externalModuleName = getExternalModuleNameLiteral(factory, node, currentSourceFile, host, resolver, compilerOptions); | ||
| const firstArgument = visitNode(firstOrUndefined(node.arguments), moduleExpressionElementVisitor); | ||
| // Only use the external module name if it differs from the first argument. This allows us to preserve the quote style of the argument on output. |
There was a problem hiding this comment.
If we really wanted to, couldn't we copy the quote style from the first argument string, if present?
There was a problem hiding this comment.
We don't preserve quote-style on parse, and this is how we handle strings everywhere else (copy from source text if possible).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
import()emit for bundled SystemJS/AMD output.Fixes #37429