8000 Use getters to define live export bindings refresh by weswigham · Pull Request #35967 · microsoft/TypeScript · GitHub
[go: up one dir, main page]
Skip to content

Use getters to define live export bindings refresh #35967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Feb 24, 2020
Merged

Use getters to define live export bindings refresh #35967

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
a8d6c2b
use getters to define live export bindings
mlrawlings Sep 24, 2019
27941d0
fix scoping in export* helper
mlrawlings Sep 25, 2019
0b2cf9b
Object.defineProperty cannot be used in ES3 target
mlrawlings Dec 16, 2019
96101aa
Merge branch 'master' into live-bindings
weswigham Jan 2, 2020
3ca0f40
Accept changed baselines
weswigham Jan 2, 2020
2002062
Use function expression, not arrow function
weswigham Jan 2, 2020
48dc607
Update importStarHelper to match export helper in binding-making
weswigham Jan 2, 2020
4f24ad3
Fix whitespace
weswigham Jan 2, 2020
8935d49
Adjust whitespace in edited helpers
weswigham Jan 3, 2020
19bb023
Use new helper for setting bindings, use unscoped __exportStar helper…
weswigham Jan 6, 2020
ca45516
Merge branch 'master' into live-bindings
weswigham Jan 6, 2020
deb3aeb
Accept updated baselines
weswigham Jan 6, 2020
3fa1d0f
Use __createBinding for individual reexports when target is es3
weswigham Jan 6, 2020
c5c8825
Remove unneeded type assertion
weswigham Jan 7, 2020
da8b58a
Merge branch 'master' into live-bindings
weswigham Feb 14, 2020
8c2762e
Merge branch 'master' into live-bindings
weswigham Feb 24, 2020
2e857dc
Singeline the helpers
weswigham Feb 24, 2020
6776f4c
Add check for createBinding helper, accept updated baselines with sho…
weswigham Feb 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use function expression, not arrow function
  • Loading branch information
@weswigham
weswigham committed Jan 2, 2020
commit 2002062fcdbf023f9b3f02b0708cd5cbf0be94f9
7 changes: 4 additions & 3 deletions src/compiler/transformers/module/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1548,13 +1548,14 @@ namespace ts {
createLiteral(name),
createObjectLiteral([
createPropertyAssignment("enumerable", createLiteral(/*value*/ true)),
createPropertyAssignment("get", createArrowFunction(
createPropertyAssignment("get", createFunctionExpression(
/*modifiers*/ undefined,
/*asteriskToken*/ undefined,
/*name*/ undefined,
/*typeParameters*/ undefined,
/*parameters*/ [],
/*type*/ undefined,
/*equalsGreaterThanToken*/ undefined,
value
createBlock([createReturn(value)])
))
])
]
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/commentsOnRequireStatement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
// blah
// blah
var _0_1 = require("./0");
Object.defineProperty(exports, "subject", { enumerable: true, get: () => _0_1.subject });
Object.defineProperty(exports, "subject", { enumerable: true, get: function () { return _0_1.subject; } });
/* blah1 */
var _1_1 = require("./1");
Object.defineProperty(exports, "subject1", { enumerable: true, get: () => _1_1.subject1 });
Object.defineProperty(exports, "subject1", { enumerable: true, get: function () { return _1_1.subject1; } });
2 changes: 1 addition & 1 deletion tests/baselines/reference/declarationEmitExportDeclaration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ exports.bar = bar;
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
var utils_1 = require("./utils");
Object.defineProperty(exports, "bar", { enumerable: true, get: () => utils_1.bar });
Object.defineProperty(exports, "bar", { enumerable: true, get: function () { return utils_1.bar; } });
utils_1.foo();
var obj;

Expand Down
8 changes: 4 additions & 4 deletions tests/baselines/reference/es6ExportClauseWithoutModuleSpecifierInEs5.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ exports.x = 10;
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
var server_1 = require("./server");
Object.defineProperty(exports, "c", { enumerable: true, get: () => server_1.c });
Object.defineProperty(exports, "c", { enumerable: true, get: function () { return server_1.c; } });
var server_2 = require("./server");
Object.defineProperty(exports, "c2", { enumerable: true, get: () => server_2.c });
Object.defineProperty(exports, "c2", { enumerable: true, get: function () { return server_2.c; } });
var server_3 = require("./server");
Object.defineProperty(exports, "instantiatedModule", { enumerable: true, get: () => server_3.m });
Object.defineProperty(exports, "instantiatedModule", { enumerable: true, get: function () { return server_3.m; } });
var server_4 = require("./server");
Object.defineProperty(exports, "x", { enumerable: true, get: () => server_4.x });
Object.defineProperty(exports, "x", { enumerable: true, get: function () { return server_4.x; } });


//// [server.d.ts]
Expand Down
24 changes: 12 additions & 12 deletions tests/baselines/reference/exportsAndImports1-amd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,21 +65,21 @@ define(["require", "exports"], function (require, exports) {
define(["require", "exports", "./t1"], function (require, exports, t1_1) {
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
Object.defineProperty(exports, "v", { enumerable: true, get: () => t1_1.v });
Object.defineProperty(exports, "f", { enumerable: true, get: () => t1_1.f });
Object.defineProperty(exports, "C", { enumerable: true, get: () => t1_1.C });
Object.defineProperty(exports, "E", { enumerable: true, get: () => t1_1.E });
Object.defineProperty(exports, "M", { enumerable: true, get: () => t1_1.M });
Object.defineProperty(exports, "a", { enumerable: true, get: () => t1_1.a });
Object.defineProperty(exports, "v", { enumerable: true, get: function () { return t1_1.v; } });
Object.defineProperty(exports, "f", { enumerable: true, get: function () { return t1_1.f; } });
Object.defineProperty(exports, "C", { enumerable: true, get: function () { return t1_1.C; } });
Object.defineProperty(exports, "E", { enumerable: true, get: function () { return t1_1.E; } });
Object.defineProperty(exports, "M", { enumerable: true, get: function () { return t1_1.M; } });
Object.defineProperty(exports, "a", { enumerable: true, get: function () { return t1_1.a; } });
});
//// [t3.js]
define(["require", "exports", "./t1"], function (require, exports, t1_1) {
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
Object.defineProperty(exports, "v", { enumerable: true, get: () => t1_1.v });
Object.defineProperty(exports, "f", { enumerable: true, get: () => t1_1.f });
Object.defineProperty(exports, "C", { enumerable: true, get: () => t1_1.C });
Object.defineProperty(exports, "E", { enumerable: true, get: () => t1_1.E });
Object.defineProperty(exports, "M", { enumerable: true, get: () => t1_1.M });
Object.defineProperty(exports, "a", { enumerable: true, get: () => t1_1.a });
Object.defineProperty(exports, "v", { enumerable: true, get: function () { return t1_1.v; } });
Object.defineProperty(exports, "f", { enumerable: true, get: function () { return t1_1.f; } });
Object.defineProperty(exports, "C", { enumerable: true, get: function () { return t1_1.C; } });
Object.defineProperty(exports, "E", { enumerable: true, get: function () { return t1_1.E; } });
Object.defineProperty(exports, "M", { enumerable: true, get: function () { return t1_1.M; } });
Object.defineProperty(exports, "a", { enumerable: true, get: function () { return t1_1.a; } });
});
24 changes: 12 additions & 12 deletions tests/baselines/reference/exportsAndImports1-es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,19 +60,19 @@ exports.a = a;
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
var t1_1 = require("./t1");
Object.defineProperty(exports, "v", { enumerable: true, get: () => t1_1.v });
Object.defineProperty(exports, "f", { enumerable: true, get: () => t1_1.f });
Object.defineProperty(exports, "C", { enumerable: true, get: () => t1_1.C });
Object.defineProperty(exports, "E", { enumerable: true, get: () => t1_1.E });
Object.defineProperty(exports, "M", { enumerable: true, get: () => t1_1.M });
Object.defineProperty(exports, "a", { enumerable: true, get: () => t1_1.a });
Object.defineProperty(exports, "v", { enumerable: true, get: function () { return t1_1.v; } });
Object.defineProperty(exports, "f", { enumerable: true, get: function () { return t1_1.f; } });
Object.defineProperty(exports, "C", { enumerable: true, get: function () { return t1_1.C; } });
Object.defineProperty(exports, "E", { enumerable: true, get: function () { return t1_1.E; } });
Object.defineProperty(exports, "M", { enumerable: true, get: function () { return t1_1.M; } });
Object.defineProperty(exports, "a", { enumerable: true, get: function () { return t1_1.a; } });
//// [t3.js]
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
const t1_1 = require("./t1");
Object.defineProperty(exports, "v", { enumerable: true, get: () => t1_1.v });
Object.defineProperty(exports, "f", { enumerable: true, get: () => t1_1.f });
Object.defineProperty(exports, "C", { enumerable: true, get: () => t1_1.C });
Object.defineProperty(exports, "E", { enumerable: true, get: () => t1_1.E });
Object.defineProperty(exports, "M", { enumerable: true, get: () => t1_1.M });
Object.defineProperty(exports, "a", { enumerable: true, get: () => t1_1.a });
Object.defineProperty(exports, "v", { enumerable: true, get: function () { return t1_1.v; } });
Object.defineProperty(exports, "f", { enumerable: true, get: function () { return t1_1.f; } });
Object.defineProperty(exports, "C", { enumerable: true, get: function () { return t1_1.C; } });
Object.defineProperty(exports, "E", { enumerable: true, get: function () { return t1_1.E; } });
Object.defineProperty(exports, "M", { enumerable: true, get: function () { return t1_1.M; } });
Object.defineProperty(exports, "a", { enumerable: true, get: function () { return t1_1.a; } });
8 changes: 4 additions & 4 deletions tests/baselines/reference/exportsAndImports2-amd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ define(["require", "exports"], function (require, exports) {
define(["require", "exports", "./t1"], function (require, exports, t1_1) {
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
Object.defineProperty(exports, "y", { enumerable: true, get: () => t1_1.x });
Object.defineProperty(exports, "x", { enumerable: true, get: () => t1_1.y });
Object.defineProperty(exports, "y", { enumerable: true, get: function () { return t1_1.x; } });
Object.defineProperty(exports, "x", { enumerable: true, get: function () { return t1_1.y; } });
});
//// [t3.js]
define(["require", "exports", "./t1"], function (require, exports, t1_1) {
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
Object.defineProperty(exports, "y", { enumerable: true, get: () => t1_1.x });
Object.defineProperty(exports, "x", { enumerable: true, get: () => t1_1.y });
Object.defineProperty(exports, "y", { enumerable: true, get: function () { return t1_1.x; } });
Object.defineProperty(exports, "x", { enumerable: true, get: function () { return t1_1.y; } });
});
8 changes: 4 additions & 4 deletions tests/baselines/reference/exportsAndImports2-es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ exports.y = "y";
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
var t1_1 = require("./t1");
Object.defineProperty(exports, "y", { enumerable: true, get: () => t1_1.x });
Object.defineProperty(exports, "x", { enumerable: true, get: () => t1_1.y });
Object.defineProperty(exports, "y", { enumerable: true, get: function () { return t1_1.x; } });
Object.defineProperty(exports, "x", { enumerable: true, get: function () { return t1_1.y; } });
//// [t3.js]
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
const t1_1 = require("./t1");
Object.defineProperty(exports, "y", { enumerable: true, get: () => t1_1.x });
Object.defineProperty(exports, "x", { enumerable: true, get: () => t1_1.y });
Object.defineProperty(exports, "y", { enumerable: true, get: function () { return t1_1.x; } });
Object.defineProperty(exports, "x", { enumerable: true, get: function () { return t1_1.y; } });
24 changes: 12 additions & 12 deletions tests/baselines/reference/exportsAndImports3-amd.js
10000
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,21 +67,21 @@ define(["require", "exports"], function (require, exports) {
define(["require", "exports", "./t1"], function (require, exports, t1_1) {
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
Object.defineProperty(exports, "v", { enumerable: true, get: () => t1_1.v1 });
Object.defineProperty(exports, "f", { enumerable: true, get: () => t1_1.f1 });
Object.defineProperty(exports, "C", { enumerable: true, get: () => t1_1.C1 });
Object.defineProperty(exports, "E", { enumerable: true, get: () => t1_1.E1 });
Object.defineProperty(exports, "M", { enumerable: true, get: () => t1_1.M1 });
Object.defineProperty(exports, "a", { enumerable: true, get: () => t1_1.a1 });
Object.defineProperty(exports, "v", { enumerable: true, get: function () { return t1_1.v1; } });
Object.defineProperty(exports, "f", { enumerable: true, get: function () { return t1_1.f1; } });
Object.defineProperty(exports, "C", { enumerable: true, get: function () { return t1_1.C1; } });
Object.defineProperty(exports, "E", { enumerable: true, get: function () { return t1_1.E1; } });
Object.defineProperty(exports, "M", { enumerable: true, get: function () { return t1_1.M1; } });
Object.defineProperty(exports, "a", { enumerable: true, get: function () { return t1_1.a1; } });
});
//// [t3.js]
define(["require", "exports", "./t1"], function (require, exports, t1_1) {
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
Object.defineProperty(exports, "v", { enumerable: true, get: () => t1_1.v1 });
Object.defineProperty(exports, "f", { enumerable: true, get: () => t1_1.f1 });
Object.defineProperty(exports, "C", { enumerable: true, get: () => t1_1.C1 });
Object.defineProperty(exports, "E", { enumerable: true, get: () => t1_1.E1 });
Object.defineProperty(exports, "M", { enumerable: true, get: () => t1_1.M1 });
Object.defineProperty(exports, "a", { enumerable: true, get: () => t1_1.a1 });
Object.defineProperty(exports, "v", { enumerable: true, get: function () { return t1_1.v1; } });
Object.defineProperty(exports, "f", { enumerable: true, get: function () { return t1_1.f1; } });
Object.defineProperty(exports, "C", { enumerable: true, get: function () { return t1_1.C1; } });
Object.defineProperty(exports, "E", { enumerable: true, get: function () { return t1_1.E1; } });
Object.defineProperty(exports, "M", { enumerable: true, get: function () { return t1_1.M1; } });
Object.defineProperty(exports, "a", { enumerable: true, get: function () { return t1_1.a1; } });
});
24 changes: 12 additions & 12 deletions tests/baselines/reference/exportsAndImports3-es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,19 +62,19 @@ exports.a1 = exports.a;
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
var t1_1 = require("./t1");
Object.defineProperty(exports, "v", { enumerable: true, get: () => t1_1.v1 });
Object.defineProperty(exports, "f", { enumerable: true, get: () => t1_1.f1 });
Object.defineProperty(exports, "C", { enumerable: true, get: () => t1_1.C1 });
Object.defineProperty(exports, "E", { enumerable: true, get: () => t1_1.E1 });
Object.defineProperty(exports, "M", { enumerable: true, get: () => t1_1.M1 });
Object.defineProperty(exports, "a", { enumerable: true, get: () => t1_1.a1 });
Object.defineProperty(exports, "v", { enumerable: true, get: function () { return t1_1.v1; } });
Object.defineProperty(exports, "f", { enumerable: true, get: function () { return t1_1.f1; } });
Object.defineProperty(exports, "C", { enumerable: true, get: function () { return t1_1.C1; } });
Object.defineProperty(exports, "E", { enumerable: true, get: function () { return t1_1.E1; } });
Object.defineProperty(exports, "M", { enumerable: true, get: function () { return t1_1.M1; } });
Object.defineProperty(exports, "a", { enumerable: true, get: function () { return t1_1.a1; } });
//// [t3.js]
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
const t1_1 = require("./t1");
Object.defineProperty(exports, "v", { enumerable: true, get: () => t1_1.v1 });
Object.defineProperty(exports, "f", { enumerable: true, get: () => t1_1.f1 });
Object.defineProperty(exports, "C", { enumerable: true, get: () => t1_1.C1 });
Object.defineProperty(exports, "E", { enumerable: true, get: () => t1_1.E1 });
Object.defineProperty(exports, "M", { enumerable: true, get: () => t1_1.M1 });
Object.defineProperty(exports, "a", { enumerable: true, get: () => t1_1.a1 });
Object.defineProperty(exports, "v", { enumerable: true, get: function () { return t1_1.v1; } });
Object.defineProperty(exports, "f", { enumerable: true, get: function () { return t1_1.f1 F987 ; } });
Object.defineProperty(exports, "C", { enumerable: true, get: function () { return t1_1.C1; } });
Object.defineProperty(exports, "E", { enumerable: true, get: function () { return t1_1.E1; } });
Object.defineProperty(exports, "M", { enumerable: true, get: function () { return t1_1.M1; } });
Object.defineProperty(exports, "a", { enumerable: true, get: function () { return t1_1.a1; } });
4 changes: 2 additions & 2 deletions tests/baselines/reference/exportsAndImports4-amd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,15 @@ define(["require", "exports", "./t1", "./t1", "./t1", "./t1", "./t1", "./t1"], f
t1_1.default;
exports.c = c;
c.default;
Object.defineProperty(exports, "d", { enumerable: true, get: () => t1_2.default });
Object.defineProperty(exports, "d", { enumerable: true, get: function () { return t1_2.default; } });
t1_2.default;
var e2 = t1_3;
exports.e1 = t1_3.default;
exports.e2 = e2;
t1_3.default;
e2.default;
exports.f1 = t1_4.default;
Object.defineProperty(exports, "f2", { enumerable: true, get: () => t1_4.default });
Object.defineProperty(exports, "f2", { enumerable: true, get: function () { return t1_4.default; } });
t1_4.default;
t1_4.default;
});
4 changes: 2 additions & 2 deletions tests/baselines/reference/exportsAndImports4-es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const c = require("./t1");
exports.c = c;
c.default;
const t1_2 = require("./t1");
Object.defineProperty(exports, "d", { enumerable: true, get: () => t1_2.default });
Object.defineProperty(exports, "d", { enumerable: true, get: function () { return t1_2.default; } });
t1_2.default;
const t1_3 = require("./t1"), e2 = t1_3;
exports.e1 = t1_3.default;
Expand All @@ -64,6 +64,6 @@ t1_3.default;
e2.default;
const t1_4 = require("./t1");
exports.f1 = t1_4.default;
Object.defineProperty(exports, "f2", { enumerable: true, get: () => t1_4.default });
Object.defineProperty(exports, "f2", { enumerable: true, get: function () { return t1_4.default; } });
t1_4.default;
t1_4.default;
4 changes: 2 additions & 2 deletions tests/baselines/reference/exportsAndImports4.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ var c = require("./t1");
exports.c = c;
c.default;
var t1_2 = require("./t1");
Object.defineProperty(exports, "d", { enumerable: true, get: () => t1_2.default });
Object.defineProperty(exports, "d", { enumerable: true, get: function () { return t1_2.default; } });
t1_2.default;
var t1_3 = require("./t1"), e2 = t1_3;
exports.e1 = t1_3.default;
Expand All @@ -64,6 +64,6 @@ t1_3.default;
e2.default;
var t1_4 = require("./t1");
exports.f1 = t1_4.default;
Object.defineProperty(exports, "f2", { enumerable: true, get: () => t1_4.default });
Object.defineProperty(exports, "f2", { enumerable: true, get: function () { return t1_4.default; } });
t1_4.default;
t1_4.default;
2 changes: 1 addition & 1 deletion tests/baselines/reference/isolatedModulesImportExportElision.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,5 @@ var C = /** @class */ (function (_super) {
var x = new module_1.c();
var y = ns.value;
var module_3 = require("module");
Object.defineProperty(exports, "c1", { enumerable: true, get: () => module_3.c1 });
Object.defineProperty(exports, "c1", { enumerable: true, get: function () { return module_3.c1; } });
exports.z = x;
2 changes: 1 addition & 1 deletion tests/baselines/reference/jsDeclarationsExportForms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ __export(require("./cls"));
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
var cls_1 = require("./cls");
Object.defineProperty(exports, "Foo", { enumerable: true, get: () => cls_1.Foo });
Object.defineProperty(exports, "Foo", { enumerable: true, get: function () { return cls_1.Foo; } });
//// [bat.js]
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/jsDeclarationsExportSpecifierNonlocal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ exports.OtherThing = OtherThing;
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
var source_1 = require("./source");
Object.defineProperty(exports, "Thing", { enumerable: true, get: () => source_1.Thing });
Object.defineProperty(exports, "default", { enumerable: true, get: () => source_1.OtherThing });
Object.defineProperty(exports, "Thing", { enumerable: true, get: function () { return source_1.Thing; } });
Object.defineProperty(exports, "default", { enumerable: true, get: function () { return source_1.OtherThing; } });


//// [source.d.ts]
Expand Down
Loading
0