8000 Local types by ahejlsberg · Pull Request #3266 · microsoft/TypeScript · GitHub
[go: up one dir, main page]
Skip to content

Local types #3266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 31, 2015
Merged

Local types #3266

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
af8aefd
Single function to parse statements and module elements
ahejlsberg May 23, 2015
375516e
Consistent formatting of optional argument comments
ahejlsberg May 23, 2015
df9378e
Allow local interface, type alias, and enum declarations
ahejlsberg May 23, 2015
cf40696
Validate that only module level declarations have modifiers
ahejlsberg May 23, 2015
10e940a
Support local generic types within generic classes and functions
ahejlsberg May 24, 2015
142605c
Accepting new baselines
ahejlsberg May 24, 2015
e053cb8
Adding comments
ahejlsberg May 25, 2015
f957427
Local types not in scope in parameter lists and return types
ahejlsberg May 26, 2015
5eff0a5
Adding tests
ahejlsberg May 26, 2015
50ebc2b
Addressing CR feedback
ahejlsberg May 26, 2015
b28f74e
Adding a few more comments
ahejlsberg May 26, 2015
26b955a
Addressing more CR feedback
ahejlsberg May 29, 2015
3f99b74
Display nested generic types as f<A>.g<B>.C<X, Y>
ahejlsberg May 30, 2015
143fd5d
New test and baselines
ahejlsberg May 30, 2015 8000
db30e57
Removing unnecessary logic
ahejlsberg May 30, 2015
a2783ed
Merge branch 'master' into localTypes
ahejlsberg May 30, 2015
f0ac90f
Accepting new baselines
ahejlsberg May 30, 2015
6f734d6
Addressing CR feedback
ahejlsberg May 31, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removing unnecessary logic
  • Loading branch information
@ahejlsberg
ahejlsberg committed May 30, 2015
commit db30e5745bf92e42fb04d2175b0d644a5bb0acc3
9 changes: 1 addition & 8 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1561,7 +1561,6 @@ module ts {
let i = 0;
if (outerTypeParameters) {
let length = outerTypeParameters.length;
let group = 0;
while (i < length) {
// Find group of type arguments for type parameters with the same declaring container.
let start = i;
Expand All @@ -1572,16 +1571,10 @@ module ts {
// When type parameters are their own type arguments for the whole group (i.e. we have
// the default outer type arguments), we don't show the group.
if (!rangeEquals(outerTypeParameters, typeArguments, start, i)) {
if (group) {
writePunctuation(writer, SyntaxKind.DotToken);
}
writeSymbolTypeReference(parent, typeArguments, start, i);
group++;
writePunctuation(writer, SyntaxKind.DotToken);
}
}
if (group) {
writePunctuation(writer, SyntaxKind.DotToken);
}
}
writeSymbolTypeReference(type.symbol, typeArguments, i, typeArguments.length);
}
Expand Down
0