stash

microsoft · amcasey · Apr 2, 2020 · Aug 10, 2018 · Aug 14, 2018 · Aug 14, 2018
commit 3f59aa9871509ece6d4e688cb1eb314c2cffaa62
diff --git a/src/compiler/diagnosticMessages.json b/src/compiler/diagnosticMessages.json
@@ -4563,5 +4563,25 @@
     "Add all missing imports": {
         "category": "Message",
         "code": 95064
+    },
+    "Add a return statement": {
+        "category": "Message",
+        "code": 95065
+    },
+    "Remove block body braces": {
+        "category": "Message",
+        "code": 95066
+    },
+    "Replace braces with parentheses": {
+        "category": "Message",
+        "code": 95067
+    },
+    "Wrap this block with parentheses": {
+        "category": "Message",
+        "code": 95068
+    },
+    "Surmise all return value": {
+        "category": "Message",
+        "code": 95069
     }
 }
diff --git a/src/services/codefixes/returnValueSurmise.ts b/src/services/codefixes/returnValueSurmise.ts
@@ -0,0 +1,50 @@
+/* @internal */
+namespace ts.codefix {
+    const fixId = "returnValueSurmise";
+    const errorCodes = [
+        Diagnostics.A_function_whose_declared_type_is_neither_void_nor_any_must_return_a_value.code,
+        Diagnostics.Type_0_is_not_assignable_to_type_1.code,
+        Diagnostics.Argument_of_type_0_is_not_assignable_to_parameter_of_type_1.code
+    ];
+    registerCodeFix({
+        errorCodes,
+        getCodeActions: context => {
+            const { host, sourceFile, span: { start } } = context;
+            return packageName === undefined ? []
+                : [createCodeFixAction(fixId, /*changes*/ [], [Diagnostics.Install_0, packageName], fixId, Diagnostics.Install_all_missing_types_packages, getCommand(sourceFile.fileName, packageName))];
+        },
+        fixIds: [fixId],
+        getAllCodeActions: context => codeFixAll(context, errorCodes, (_, diag, commands) => {
+            const pkg = getTypesPackageNameToInstall(context.host, diag.file, diag.start, diag.code);
+            if (pkg) {
+                commands.push(getCommand(diag.file.fileName, pkg));
+            }
+        }),
+    });
+
+    interface Info {
+
+    }
+
+    function getInfo (checker: TypeChecker, sourceFile: SourceFile, position: number): Info | undefined {
+        const node = getTokenAtPosition(sourceFile, position);
+        if (!node.parent) return undefined;
+
+        if (isTypeNode(node) && isFunctionLikeDeclaration(node.parent)) {
+
+        }
+        else if (isDeclarationName(node) && isVariableLike(node.parent)) {
+
+        }
+        else {
+            Debug.fail('unknow pattern');
+        }
+
+
+        const functionLikeDeclaration = cast(node.parent, isFunctionLike);
+        Debug.assert(functionLikeDeclaration.type === node);
+
+        const returnType = checker.getTypeFromTypeNode(cast(node, isTypeNode));
+
+    }
+}
diff --git a/src/services/tsconfig.json b/src/services/tsconfig.json
@@ -51,6 +51,7 @@
         "codefixes/fixClassIncorrectlyImplementsInterface.ts",
         "codefixes/importFixes.ts",
         "codefixes/fixSpelling.ts",
+        "codefixes/returnValueSurmise.ts",
         "codefixes/fixAddMissingMember.ts",
         "codefixes/fixCannotFindModule.ts",
         "codefixes/fixClassDoesntImplementInheritedAbstractMember.ts",