8000 Parse and check type arguments on JSX opening and self-closing tags by weswigham · Pull Request #22415 · microsoft/TypeScript · GitHub
[go: up one dir, main page]
Skip to content

Parse and check type arguments on JSX opening and self-closing tags #22415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Parse and check type arguments on JSX opening and self-closing tags #22415

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23f1e8d
Parse and check type arguments on JSX opening like elements
weswigham Mar 8, 2018
9e3f5b5
Fix nits
weswigham Mar 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix nits
  • Loading branch information
@weswigham
weswigham committed Mar 16, 2018
commit 9e3f5b50bd43f41254e8f8255d6a0c2a31c573c3
6 changes: 3 additions & 3 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17381,13 +17381,13 @@ namespace ts {
}

function getTypeArgumentArityError(node: Node, signatures: Signature[], typeArguments: NodeArray<TypeNode>) {
let min = Number.POSITIVE_INFINITY;
let max = Number.NEGATIVE_INFINITY;
let min = Infinity;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the original author didn't just use Infinity / -Infinity ?

let max = -Infinity;
for (const sig of signatures) {
min = Math.min(min, getMinTypeArgumentCount(sig.typeParameters));
max = Math.max(max, length(sig.typeParameters));
}
const paramCount = min < max ? min + "-" + max : min;
const paramCount = min === max ? min : min + "-" + max;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would find min === max ? min : min + "-" + max clearer

return createDiagnosticForNodeArray(getSourceFileOfNode(node), typeArguments, Diagnostics.Expected_0_type_arguments_but_got_1, paramCount, typeArguments.length);
}

Expand Down
0