Fix error messeage #20601
Merged
Fix error messeage #20601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, can you take a look @weswigham? |
weswigham
reviewed
Dec 11, 2017
src/compiler/scanner.ts
Outdated
| while (true) { | ||
| const ch = text.charCodeAt(pos); | ||
| // Numeric seperators are allowed anywhere within a numeric literal, except not at the beginning, or following another separator | ||
| if (ch === CharacterCodes._) { | ||
| tokenFlags |= TokenFlags.ContainsSeparator; | ||
| if (separatorAllowed) { | ||
| separatorAllowed = false; | ||
| isPreviousTokenSeparator = true; | ||
| // tslint:disable-next-line:next-line |
There was a problem hiding this comment.
Why is there a lint rule disabled here?
There was a problem hiding this comment.
Simple mistake. I remove extra lint.
weswigham
approved these changes
Dec 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20585