-
Notifications
You must be signed in to change notification settings - Fork 12.9k
[Master] wip-dynamic import #14774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[Master] wip-dynamic import #14774
Changes from 1 commit
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
787ed37
Use term UpdateExpression instead of IncrementExpression to keep it c…
ca08167
Wip-parsing import call expression
330f7bf
Correctly parse import()
e7b3a15
Merge branch 'master' into master-dynamicImport
827abb3
Parse import call and use collect its specifier
6933b58
Wip-type check dynamic import
126fb64
Wip-type check dynamic import
bd50ccf
Merge branch 'master-dynamicImport' of https://github.com/Microsoft/T…
7340d84
Rename importcall to importCallExpression
18c826b
Add new value "es2018" for module kind
ddf5ed9
Emit dynamic import when module kind is es2018
26f9a52
Add initial tests
20293b0
Fix up error when we can't find promise type in import call expression
369af08
Change filename to indicate it uses module kind of es2018
ffbb445
wip-Emit import call expression for commonjs
be375cb
Fix missing import call expression in function and class declaration
a84645c
Add more tests for emitting of es2018 module-kind
9864b4e
Emit import callExpression for UMD and AMD
86c7129
wip-system emit
6db02e7
Fix up incorrect system emit
a77f0d2
Do not collect imports in parser as it makes it very hard for increme…
dbac66c
Update baselines from adding es2018 value into moduleKind
804ab2c
Remove duplicat es2018 tests
1af1005
Correctly bind import call expression
e019216
Use emitFlags to indicate that the subtree contains dynamic import
015f71b
Issue error when use with ES2015
8fd660b
Report no implicit error when we return Promise<any>
f04f7b5
Add comment for comparable relationship
871d609
Report an error if dynamic import specifier is not assigable to type …
15ca0af
Add tests
2332ea3
small fix on indentation
91d9ecf
Simply parse dynamic import as call-expression....
c798489
Move error report of incorrect grammar in dynamic import to checker
c62f4f5
Update tests
e1ba855
Add declaration emit test and test to make sure we don't give dynamic…
265d0c0
Fix where we report noImplicitAny error in dynamic import
640f2c7
Error when dynamic import has type arguments
61f199e
Update tests
486dc91
Change comment to jsdoc
6080c3e
Remove error with noImplicitAny
32e5cf7
Fix AMD emit
249f446
Update tests
f3306db
Update baselines
11f6eae
Merge branch 'master' into master-dynamicImport
d4754db
Update baseline from merging with master
9715052
Merge branch 'master' into master-dynamicImport
ca65996
Merge branch 'master' into master-dynamicImport
faaa38d
Update PR
55430c4
Add boolean flag to not walk the tree if there is no dynamic import
78b8275
Fix linting error
d1d5cac
Address PR: Remove duplication
2b96374
fix no-bom linting rule
2f61d47
Address minor PR comment
8000
a10e668
Move check for module kind is ES2015 into grammar check; Use checkNon…
e50667e
Address minor PR comment
feb41f7
Merge branch 'master' into master-dynamicImport
742d515
Fix baselines and function call from merging master
35e2289
Address PR:
a2d9fd4
Add target ES5 emit
1b0d020
Add tests and update baselines
1b7d3bf
Merge branch 'master' into master-dynamicImport
faab927
Merge branch 'master' into master-dynamicImport
a02edb1
Address PR: don't early exit when there are grammar errors
72ba23c
Address PR: change order of grammar check
e6d7327
Address PR: error message, fix capitalization, only allow functionLik…
d9e2033
Address PR: remove __resolved when emit for commonJs and just do Prom…
769f6ad
Update baselines
2f476bf
Merge branch 'master' into master-dynamicImport
9203f95
Update name change of isSpreadExpression
4733f0d
Fix linting
c2056c0
Address minor error messages
e386d65
Use ESNext instead of ES2018
3118afe
Remove ES2018 folder
75aa4bd
Rename test file with ES2018 to ESNext
7d64ec9
Update baselines from moving out of es2018
1729ea8
Update command line
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix linting error
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As with my comments for
transformImportCallExpressionUMD
, I'd rather see this added as a scoped helper at the top of the module body function.