8000 Allow deriving from object and intersection types by ahejlsberg · Pull Request #13604 · microsoft/TypeScript · GitHub
[go: up one dir, main page]
Skip to content

Allow deriving from object and intersection types #13604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 21, 2017
Merged

Allow deriving from object and intersection types #13604

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a6c5306
Allow object intersection types as class/interface base types
ahejlsberg Jan 19, 2017
1c2f7f8
Improve efficiency of union/intersection resolved property caching
ahejlsberg Jan 19, 2017
c51e286
Allow object intersection types in class implements clauses
ahejlsberg Jan 19, 2017
f9a65e4
Accept new baselines
ahejlsberg Jan 19, 2017
a9af10b
Intersections as their own 'this' type
ahejlsberg Jan 20, 2017
c16c7d5
Allow base constructor types to be intersections
ahejlsberg Jan 20, 2017
ad71da0
Fix error reporting bug
ahejlsberg Jan 21, 2017
615784a
Add tests
ahejlsberg Jan 21, 2017
3a34cb3
Accept new baselines
ahejlsberg Jan 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allow object intersection types in class implements clauses
  • Loading branch information
@ahejlsberg
ahejlsberg committed Jan 19, 2017
commit c51e2867f50de63db151310da03b829d667becc9
3 changes: 1 addition & 2 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18411,8 +18411,7 @@ namespace ts {
if (produceDiagnostics) {
const t = getTypeFromTypeNode(typeRefNode);
if (t !== unknownType) {
const declaredType = getObjectFlags(t) & ObjectFlags.Reference ? (<TypeReference>t).target : t;
if (getObjectFlags(declaredType) & ObjectFlags.ClassOrInterface) {
if (isValidBaseType(t)) {
checkTypeAssignableTo(typeWithThis, getTypeWithThisArgument(t, type.thisType), node.name || node, Diagnostics.Class_0_incorrectly_implements_interface_1);
}
else {
Expand Down
0