E537 Disable AAD and Azure Blob local auth by zhou9584 · Pull Request #662 · microsoft/HydraLab · GitHub
[go: up one dir, main page]

Skip to content

Disable AAD and Azure Blob local auth#662

Merged
zhou9584 merged 1 commit intomainfrom
zhoule/fedSolution
Jul 15, 2024
Merged

Disable AAD and Azure Blob local auth#662
zhou9584 merged 1 commit intomainfrom
zhoule/fedSolution

Conversation

@zhou9584
Copy link
Contributor
@zhou9584 zhou9584 commented Jul 15, 2024

Description

  1. Switch access token to id token
  2. disable blob local auth and merge 6 blobs to 1
    image

Linked GitHub issue ID:

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

  • Yes
  • No

How you tested it

Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Technical design
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe):

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...

redirectUrl = state;
}
}
response.sendRedirect(redirectUrl);// CodeQL [java/unvalidated-url-redirection] False Positive: Has verified the string by regular expression

Check warning

Code scanning / CodeQL

URL redirection from remote source

Untrusted URL redirection depends on a [user-provided value](1).
@zhou9584 zhou9584 merged commit 4dc5eb4 into main Jul 15, 2024
@zhou9584 zhou9584 deleted the zhoule/fedSolution branch July 15, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0