Fix missing argument in StratifiedKFold.split() #1304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `evaluate_model_CV` method of the `generic_task.py` module, the `StratifiedKFold.split()` method was missing a required positional argument 'y'. This caused a TypeError when attempting to split the dataset for cross-validation. To address this issue, I added the missing 'y' argument to the `StratifiedKFold.split()` method call. The corrected line of code now reads: ```python kf = kf.split(X_train_split, y_train_split) ``` This modification ensures that the StratifiedKFold cross-validation splits the dataset correctly, allowing the AutoML fit method to run without encountering errors. This fix resolves the issue reported in the FLAML library when using custom StratifiedKFold cross-validation.
Contributor
Author
|
@microsoft-github-policy-service agree |
Borda
reviewed
Aug 12, 2024
| state.fit_kwargs[ | ||
| "sample_weight" | ||
| ] = ( | ||
| state.fit_kwargs["sample_weight"] = ( |
Collaborator
There was a problem hiding this comment.
lets reduce the change, keep it focus
Contributor
Author
There was a problem hiding this comment.
could you elaborate? thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
evaluate_model_CVmethod of thegeneric_task.pymodule, theStratifiedKFold.split()method was missing a required positional argument 'y'. This caused a TypeError when attempting to split the dataset for cross-validation.To address this issue #1303, I added the missing 'y' argument to the
StratifiedKFold.split()method call. The corrected line of code now reads:This modification ensures that the StratifiedKFold cross-validation splits the dataset correctly, allowing the AutoML fit method to run without encountering errors.
This fix resolves the issue reported in the FLAML library when using custom StratifiedKFold cross-validation.
Why are these changes needed?
Related issue number
Checks