This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Merged
Conversation
vineeththomasalex
approved these changes
Mar 1, 2024
EricJohnson327
approved these changes
Mar 1, 2024
This was referenced Mar 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Renames the extension of the logs to ".dhlog". The previous extension, ".log" is very generic and does not have any implication of format of the log file. For tooling to better read, parse, and gather Dev Home logs this change was made to something more specific to Dev Home while still being human-readable and easily identifiable as a log file.
We do not require absolute uniqueness here, and I did not find any common or known file extensions today that use ".dhlog", so this is reasonably and sufficiently unique for our purposes of improving dev home log identification.
After this is changed I will change it in DevHome and the github extension as well. I wanted to start with one PR for the name change so if there is objection or differences the feedback can be incorporated in one place first.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist