8000 Fix out of memory error in ESP 32 by jaejeong1 · Pull Request #513 · micropython/micropython-lib · GitHub
[go: up one dir, main page]
Skip to content

Fix out of memory error in ESP 32 #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in t 8000 o your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix out of memory error in ESP 32 #513

wants to merge 1 commit into from

Conversation

jaejeong1
Copy link

Delete the wrap_socket causing the problem

@jaejeong1
Fix out of memory error in ESP 32
a981796 
Delete the wrap_socket causing the problem
@andrewleech
Copy link
Contributor

I would expect these lines are needed for https support though?

@sosi-deadeye
Copy link

This won't fix anything, introduces a bug and makes https for all unusable.

Redirects are not supported yet, so you can't be redirected accidentally to https if you're using http. If you're using https it will trigger the OSError: [Errno 12] ENOMEM exception on Boards with less memory.

@mattytrentini
Copy link
Contributor

Redirects have been implemented in [urequests](https://github.com/micropython/micropython-lib/tree/master/python-ecosys/urequests) (as well as a whole host of other fixes) and we should probably update urlib.urequest to use the same code.

@jimmo
Copy link
Member
jimmo commented Aug 5, 2022

@jaejeong1 thanks but this is not the right solution as the other comments have pointed out.

We are working to fix this issue in the ESP32 SSL implementation, see micropython/micropython#8940 for the main issue tracking this.

@jimmo jimmo closed this Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaejeong1 @andrewleech @sosi-deadeye @mattytrentini @jimmo
0