This repository was archived by the owner on Sep 6, 2023. It is now read-only.
ports/esp32/modnetwork.c: Reliably tell the status with isconnected() #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The status will be changed by the event notification. There is still a small lag between the python command affecting the status and the status change.
|
Note: This aims at fixing issue #212 |
|
I've just tested the provided patch - it's fine. |
|
Sorry I missed this. It looks like micropython/micropython#3838 is doing a similar thing and maybe more robust than this in case the IP address is statically assigned. |
|
Should be fixed by commit in main repo: micropython/micropython@039f196 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status will be changed by the event notifications. There is still a
small lag between the python command affecting the status and the
status change.
Also, after an intentional disconnect() do not try to reconnect automatically.