py/obj.h: Add m_new_obj_with_type macro. #8576
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgeorge
reviewed
Apr 22, 2022
dpgeorge
reviewed
Apr 22, 2022
dpgeorge
reviewed
Apr 22, 2022
450e986 to
1114a6c
Compare
Codecov Report
@@ Coverage Diff @@
## master #8576 +/- ##
==========================================
- Coverage 98.23% 98.22% -0.01%
==========================================
Files 154 154
Lines 20364 20311 -53
==========================================
- Hits 20004 19951 -53
Misses 360 360
Continue to review full report at Codecov.
|
|
please rebase on latest master to pick up new renesas-ra port, which has 7 uses of |
|
Done. Not all 7 were suitable (two in timer.c immediately memset, and in mpthreadport.c it isn't actually an object). |
|
The first commit includes changes to In the second commit some cc3200 HAL files are unnecessarily changed (maybe line endings?). |
This is to replace the following: mp_foo_obj_t *self = m_new_obj(mp_foo_obj_t); self->base.type = &mp_type_foo; with: mp_foo_obj_t *self = mp_obj_malloc(mp_foo_obj_t, &mp_type_foo); Calling the function is less code than inlining setting the type everywhere, adds up to ~100 bytes on PYBV11. It also helps to avoid an easy mistake of forgetting to set the type. Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
8000
This replaces occurences of foo_t *foo = m_new_obj(foo_t); foo->base.type = &foo_type; with foo_t *foo = mp_obj_malloc(foo_t, &foo_type); Excludes any places where base is a sub-field or when new0/memset is used. Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
|
Done. |
iabdalkader
added a commit
to iabdalkader/micropython
that referenced
this pull request
Jun 9, 2022
* Changes introduced in micropython#8576 missed changing this call to mp_obj_malloc.
dlech
added a commit
to dlech/micropython
that referenced
this pull request
May 7, 2023
This makes use of mp_obj_malloc() in more places to reduce binary size. Also see micropython#8576. Signed-off-by: David Lechner <david@pybricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to replace the following:
with:
Calling the function is less code than inlining setting the type everywhere, adds up to 100 bytes on PYBV11. Small, but every byte counts, right? :p
It also helps to avoid an easy mistake of forgetting to set the type.
Perf impact is negligible, possibly even improved? I specifically excluded
mp_obj_new_floatfrom using this (otherwise there was about a 1% decrease across the fp-heavy tests).