8000 extmod/uasyncio: fix gather cancellation and handling of exceptions by dpgeorge · Pull Request #8459 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

extmod/uasyncio: fix gather cancellation and handling of exceptions #8459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2022
Merged

extmod/uasyncio: fix gather cancellation and handling of exceptions #8459

merged 2 commits into from
Mar 30, 2022

Conversation

dpgeorge
Copy link
Member

The following fixes are made to asyncio.gather():

  • cancelling a gather now cancels all sub-tasks of the gather (previously it would only cancel the first)
  • if any sub-task of a gather raises an exception then the gather finishes (previously it would only finish if the first sub-task raised)

Fixes issues #5798, #7807, #7901.

@dpgeorge dpgeorge added the extmod Relates to extmod/ directory in source label Mar 29, 2022
@dpgeorge dpgeorge force-pushed the extmod-uasyncio-improve-gather branch from 07fbcf6 to e9eba8f Compare March 29, 2022 10:41
dpgeorge added 2 commits March 30, 2022 16:07
@dpgeorge
extmod/uasyncio: Allow task state to be a callable.
335002a 
This implements a form of CPython's "add_done_callback()", but at this
stage it is a hidden feature and only intended to be used internally.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge
extmod/uasyncio: Fix gather cancelling and handling of exceptions.
90aaf2d 
The following fixes are made:
- cancelling a gather now cancels all sub-tasks of the gather (previously
  it would only cancel the first)
- if any sub-task of a gather raises an exception then the gather finishes
  (previously it would only finish if the first sub-task raised)

Fixes issues micropython#5798, micropython#7807, micropython#7901.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the extmod-uasyncio-improve-gather branch from e9eba8f to 90aaf2d Compare March 30, 2022 05:08
@dpgeorge dpgeorge merged commit 90aaf2d into micropython:master Mar 30, 2022
@dpgeorge dpgeorge deleted the extmod-uasyncio-improve-gather branch March 30, 2022 05:28
@jepler jepler mentioned this pull request Oct 18, 2022
Closed
tannewt added a commit to tannewt/circuitpython that referenced this pull request Oct 20, 2023
@tannewt
Merge pull request micropython#8459 from tannewt/metro_s3_revb
2de11f0 
Update Metro S3 pin mapping for Rev B
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
extmod Relates to extmod/ directory in source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dpgeorge
0