10000 extmod/ports: Provide a common `uos` module implementation by dpgeorge · Pull Request #8388 · micropython/micropython · GitHub
[go: up one dir, main page]

Skip to content

extmod/ports: Provide a common uos module implementation #8388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 9, 2022

Conversation

dpgeorge
Copy link
Member
@dpgeorge dpgeorge commented Mar 7, 2022

This PR creates a common extmod/moduos.c implementation and switches the following ports to use it:

  • rp2
  • esp32
  • zephyr
  • samd
  • qemu-arm
  • mimxrt
  • stm32
  • esp8266

nrf and cc3200 ports are left for a later time because they are much more involved to convert.

unix port will be converted separately, because it's also involved.

@dpgeorge dpgeorge added the extmod Relates to extmod/ directory in source label Mar 7, 2022
@dpgeorge dpgeorge changed the title Extmod common moduos extmod/ports: Provide a common uos module implementation Mar 7, 2022
@robert-hh
Copy link
Contributor

Tried with Teensy4.1 (mimxrt1062), Olimex rt1010 (mimxrt1011) and MIMXRT1020_DEV (mimxrt1021). Works fine. Adapting all my open branches may get a little bit of work. Git has it's challenge with Makefile.

@dpgeorge
Copy link
Member Author
dpgeorge commented Mar 7, 2022

Thanks for testing on mimxrt. This is not urgent, it doesn't need to go in now, it can wait. (But there will always be outstanding PRs, and it can't wait forever...).

@robert-hh
Copy link
Contributor

Merge it anytime you like. I did not mean to defer it.

dpgeorge added 8 commits March 9, 2022 10:03
Based on the rp2 port version, with the rp2 port converted to use this
module.

Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
This also adds uos.unlink(), for all ports that use extmod/moduos.c.

Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the extmod-common-moduos branch from f21b062 to ade2720 Compare March 8, 2022 23:57
@dpgeorge dpgeorge merged commit ade2720 into micropython:master Mar 9, 2022
@dpgeorge dpgeorge deleted the extmod-common-moduos branch March 9, 2022 00:22
Wind-stormger pushed a commit to BPI-STEAM/micropython that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extmod Relates to extmod/ directory in source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0