unix/main: Insert script base dir into sys.path rather than replace existing entry. #8006
Conversation
157ae30 to
7628dd1
Compare
|
This would work to actually manage to import frozen modules, however it would change how MicroPython behaves compared to CPython. (Not sure how much this matters in practice, but I think there is a desire to keep behaviours the same where possible.) I looked into how MicroPython and CPython compare in this regard some time ago: https://gist.github.com/wnienhaus/65727fff5f4954d0e9418ffeaf9bbb6d (as part of commenting on #3509). I believe TEST4 and TEST5 in the Gist are what is relevant to this change. |
This allows any frozen code to still be found with existing empty entry. Also applies to windows port. Addresses issue micropython#2322
7628dd1 to
5d6d34d
Compare
|
Ah, this PR also triggers a version of the upip issue I was trying to fix in #7536
If upip is frozen into micropython then it should work with this change as in the default unix build |
|
@andrewleech is this still relevant now that we have |
|
Sorry yes I meant to close this one with a reference to that! |
This directly addresses issue #2322 in that it preserve the existing empty path entry at the start of
sys.pathwhich currently acts as frozen import path.This is a more minimal fix than renaming the import path for frozen in #5057
However, I am personally still very much in support of #5057 being included as well as this change, using the empty path for frozen can be quite confusing to new users; giving it something explicit is worthwhile in my opinion.
This fix also applies to the windows port.