mimxrt/machine_rtc: Change format of RTC.datetime to match other ports. #7383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien George <damien@micropython.org>
This was referenced Jun 12, 2021
|
Closed in favour of #7382. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #7318, and after discussion #6928 (comment) and also #5553.
The point of this PR is to change
RTC.datetime()on the mimxrt port to take/return an 8-tuple in the same format as most of the existing ports (stm32, esp8266, esp32). In the first version of #7318 @robert-hh did already have it this way but I suggested to change it to match CPython's datetime format (see #7318 (comment)). That suggestion was a bit eager because it just introduces too much incompatibility, see #6928 (comment) .Changes in this PR:
RTC.datetime()to take/return an 8-tuple with format(year, month, day, weekday, hour, minute, second, microsecond)RTC.weekday()RTC.now()so it returns(year, month, day, hour, minute, second, microsecond, tzinfo). This matches the docs and the cc3200 port (and no other port has thisnow()method).