8000 STM32H7: FDCAN Fixes by iabdalkader · Pull Request #6212 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

STM32H7: FDCAN Fixes #6212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

STM32H7: FDCAN Fixes #6212

wants to merge 6 commits into from

Conversation

iabdalkader
Copy link
Contributor
  • Fix fdcan can_receive fifo0 was used for both fifo0 and fifo1.
  • Check if timeout == HAL_MAX_DELAY in fdcan can_receive.
  • Cleanup use FDCAN_RXFxS_FxFL instead of hard-coded value.
  • Handle the timeout arg for FDCAN in pyb_can_send as specified in the docs.

dpgeorge
dpgeorge reviewed Jul 8, 2020
View reviewed changes
@dpgeorge
Copy link
Member
dpgeorge commented Jul 8, 2020

Thank you! Merged in 8594389 through c299cc9

@dpgeorge dpgeorge closed this Jul 8, 2020
tannewt pushed a commit to tannewt/circuitpython that referenced this pull request May 10, 2022
@dhalbert
Merge pull request micropython#6212 from dhalbert/7.2.x-6103-backport
faca1ec 
7.2.x micropython#6103 backport
@iabdalkader iabdalkader deleted the fdcan_fixes branch September 17, 2022 18:05
@iabdalkader iabdalkader mentioned this pull request Aug 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgeorge dpgeorge dpgeorge left review comments

Assignees
No one assigned
Labels
port-stm32 4673
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iabdalkader @dpgeorge
0