esp32 port: expose adjtime(3) as utime.adjtime([(sec,usec)]) #5453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussion at https://forum.micropython.org/viewtopic.php?f=18&t=7403 |
utime.adjtime() can be used to slew the system clock by a given adjustment value (as an optional (sec, usec) tuple). The system clock is not abruptly changed, but gradually adjusts the boot time. The call immediately returns, but a correction by 1 second will actually take 64 seconds in the background. The system clock remains monotonic during this time but will appear faster/slower. Called without an argument or None it will return the remaining adjustment from a previous call. If called with an adjustment value a previously running adjustment is cancelled without being undone.
|
IMHO this needs a doc update commit. Would love to see it merged then! 👍 |
tve
reviewed
Feb 5, 2020
|
|
||
| .. function:: adjtime([(secs, usecs)]) | ||
|
|
||
| This function is only available in the esp32 port. It uses the API's |
There was a problem hiding this comment.
mind fixing this? there are many APIs around whereas saying "the ESP-IDF's function" is unambiguous...
|
There is no adjtime(3) in the ESP8266 IDF. As stated in the other (closed) pull request, that port needs mor work. This one I still think is worth merging. |
|
This function can't be added to the If we were to add this (it does look useful!) then it could go in either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utime.adjtime() can be used to slew the system clock by a
given adjustment value (as an optional (sec, usec) tuple).
The system clock is not abruptly changed, but gradually
adjusts the boot time. The call immediately returns, but
a correction by 1 second will actually take 64 seconds in
the background. The system clock remains monotonic during
this time but will appear faster/slower. Called without
an argument or None it will return the remaining adjustment
from a previous call. If called with an adjustment value a
previously running adjustment is cancelled without being
undone.