8000 NUCLEO F746ZG ethernet support by cfpena · Pull Request #5076 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

NUCLEO F746ZG ethernet support #5076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

NUCLEO F746ZG ethernet support #5076

wants to merge 2 commits into from

Conversation

cfpena
Copy link
@cfpena cfpena commented Sep 6, 2019 •
edited
Loading

Tested on STM32F746ZG

@dpgeorge
Copy link
Member
dpgeorge commented Sep 8, 2019

Thanks for the contribution.

Is there a particular reason to enable threading? No other board enables it, it's usually enabled on the command line like make CFLAGS_EXTRA="-DMICROPY_PY_THREAD=1". And threading is not fully tested with networking on the stm32 port.

@cfpena
Copy link
Author
cfpena commented Sep 9, 2019

Thanks for the contribution.

Is there a particular reason to enable threading? No other board enables it, it's usually enabled on the command line like make CFLAGS_EXTRA="-DMICROPY_PY_THREAD=1". And threading is not fully tested with networking on the stm32 port.

It was a mistake, I will change the PR. Thanks :)

@cfpena cfpena closed this Sep 9, 2019
@dpgeorge
Copy link
Member

See #5085 for follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
port-stm32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cfpena @dpgeorge
0