-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
various: Add/update my copyright. #4787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR also includes #4363 , which got ignored for more than a half-year now. |
* Copyright (c) 2013, 2014 Damien P. George | ||
* Copyright (c) 2014 Paul Sokolovsky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the ordered changed here (and elsewhere)? Since 2013 is earlier than 2014 it makes sense to retain the order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed order in files which were initially created by me. I hope you would agree that it makes sense if the original author were listed first.
Also, arguably, your copyright year would be adjusted to match the real history of a file, and if you remember, I did that once in a previous patchset on this matter, but refrained from doing this again, as ultimately, you're the best party to maintain your copyright notice.
(Finally, many copyright notices in files contributed by me in early period get your copyright mostly by cut-n-paste, with rationalization that while I create some module from scratch, the structure of it is governed (and copied) from your substantial effort. While later it became clear that it doesn't scale to have any MicroPython-related file ever written to include your copyright, I obviously don't try to revision notices added at that early time.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, you're right that this file looks to be completely fresh (or at least fresh enough) at its time of creation. So I should adjust my year to match the history.
Is it intended to update axtls? |
Based on the git history, for modules I initially created or made substantial contributions to. Change-Id: Ic10a33c6b33f6210bb73ea3625d296f202fda906
…oject. Change-Id: Id40cab51cc51048771ae0799e2a12ccae1d22eb5
102191d
to
3fc3e37
Compare
Definitely not, rebased. |
* Copyright (c) 2013, 2014 Damien P. George | ||
* Copyright (c) 2014 Paul Sokolovsky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, you're right that this file looks to be completely fresh (or at least fresh enough) at its time of creation. So I should adjust my year to match the history.
@@ -3,6 +3,7 @@ | |||
* | |||
* The MIT License (MIT) | |||
* | |||
* Copyright (c) 2014-2017 Paul Sokolovsky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
@@ -3,8 +3,8 @@ | |||
* | |||
* The MIT License (MIT) | |||
* | |||
* Copyright (c) 2014-2018 Paul Sokolovsky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
@@ -3,6 +3,7 @@ | |||
* | |||
* The MIT License (MIT) | |||
* | |||
* Copyright (c) 2014-2017 Paul Sokolovsky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
@@ -3,6 +3,7 @@ | |||
* | |||
* The MIT License (MIT) | |||
* | |||
* Copyright (c) 2014 Paul Sokolovsky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
@@ -3,6 +3,7 @@ | |||
* | |||
* The MIT License (MIT) | |||
* | |||
* Copyright (c) 2015 Paul Sokolovsky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
Based on the git history, for modules I initially created or made substantial contributions to.