8000 NeoPixel timing fix by mattytrentini · Pull Request #4421 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

NeoPixel timing fix #4421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

NeoPixel timing fix #4421

wants to merge 2 commits into from

Conversation

mattytrentini
Copy link
Contributor

Resolves #4396.

Note that this is a breaking change! It changes the default behaviour of NeoPixel so the default timing is suitable for 800KHz devices instead of 400KHz

@mattytrentini
Updated NeoPixel to use different default timings to suit 800KHz by d…
a9c8ba2 
…efault (instead of 400KHz).

Resolves #4396.

Note! This is a breaking change. Anyone that has previously used the NeoPixel class may be affected.
@dpgeorge
Copy link
Member

Thanks, but I think it'd be better to change ports/esp32/modules/neopixel.py so that the constructor passes timing=1 as the default (instead of timing=0). Then it doesn't break code for users who already specify this parameter, only for those who use the default. It also means that esp8266 and esp32 have the same signature/behaviour for esp.neopixel_write().

@mattytrentini
Copy link
Contributor Author

You mean just flip it from espneopixel.c to neopixel.py, like in c2fdbe1?

@dpgeorge
Copy link
Member

You mean just flip it from espneopixel.c to neopixel.py

Yes, exactly. It looks good now.

@dpgeorge
Copy link
Member

Merged in cd52d2c

I tested this with an 8-pixel strip of WS2812B and it worked fine, both before and after this change (ie with either timing).

@dpgeorge dpgeorge closed this Jan 23, 2019
tannewt pushed a commit to tannewt/circuitpython that referenced this pull request Mar 18, 2021
@jepler
Merge pull request micropython#4421 from kattni/led-pin
75ba26e 
Adding LED for D13/L pin name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattytrentini @dpgeorge
0