8000 ESP8266: Improved time keeping by Adam5Wu · Pull Request #2726 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

ESP8266: Improved time keeping #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

ESP8266: Improved time keeping #2726

wants to merge 5 commits into from

Conversation

Adam5Wu
Copy link
@Adam5Wu Adam5Wu commented Dec 26, 2016
  1. Implement access to non-RTC system clock, which is more stable than built-in RTC;
  2. Modified general time function to use system clock instead of RTC;
  3. Implement more accurate code for tracking RTC clock.

@Adam5Wu Adam5Wu mentioned this pull request Dec 26, 2016
Open
@Adam5Wu
Removed system clock's RTC memory slot (not necessary); Persist and r…
7037442 
…estore RTC ticks from RTC memory at initialization, keeps time across machine.reset
@Adam5Wu
Handle hard reset differently from other reset when reinitializing RT…
8bcc8eb 
…C ticks.
@Adam5Wu
Copy link
Author
Adam5Wu commented Dec 27, 2016

New commits simplifies system clock time keeping, restores RTC memory usage to match that of the pre-PR implementation; properly restores clock upon reset:

  • Soft reset will have minimal impact to either RTC clock or system clock (RTC clock is used to recover system clock)
  • External hard reset will result in loss of some seconds after last RTC reading (affects both RTC and system clock), but it's better than nothing. :D

@pfalcon
Copy link
Contributor
pfalcon commented Dec 27, 2016

Thanks, but please follow https://github.com/micropython/micropython/blob/master/CONTRIBUTING.md (format of commit messages, no merge commits in pull requests, etc.)

@Adam5Wu
Copy link
Author
Adam5Wu commented Dec 27, 2016 •
edited
Loading

Sorry about that! :)
No more commits unless discussed and requested in this PR.

@Adam5Wu
Copy link
Author
Adam5Wu commented Dec 27, 2016

Actually, the current branch is a bit messy. Let me redo the branch and submit a new PR.

@Adam5Wu Adam5Wu closed this Dec 27, 2016
@Adam5Wu Adam5Wu deleted the feat_esp8266_newtime branch December 27, 2016 19:08
@Adam5Wu
Copy link
Author
Adam5Wu commented Dec 29, 2016

New PR: #2728

@pacmac
Copy link
pacmac commented Jun 22, 2017

Is it possible to resurrect this modification as what appears to be a solution to the horrendously bad accuracy of the 8266 deepsleep timer ?

@pfalcon
Copy link
Contributor
pfalcon commented Jun 22, 2017

Sure, this is still on todo - someone will need to re-research the matter and re-make the patch in clean way.

tannewt added a commit to tannewt/circuitpython that referenced this pull request Mar 31, 2020
@tannewt
Merge pull request micropython#2726 from xobs/fomu-circuitpython
f47b964 
ports: litex: add port and fomu board
@maharjanmilan
Copy link
791C

can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Adam5Wu @pfalcon @pacmac @maharjanmilan
0