move generic CMSIS files to lib/cmsis #2441
Conversation
|
Is this the latest version of CMSIS? If we are going to upgrade, why not do it in one go: upgrade and move. |
3151f82 to
fccf110
Compare
|
I thought you may want to separate those two changes too have cleaner git log. I've added second commit upgrading CMSIS headers to the newest version from ARM-software/CMSIS. Also rebased on top of current HEAD. |
Yes, thanks, having the change log is better than not having it. One last minor point: is there a reason to put the common cmsis files in lib/cmsis/inc instead of lib/cmsis? Also, I removed the stm32f2xx cmsis files in 53bfcc9, so please rebase against that. |
Files in lib/cmsis are generic for all Cortex-M MCU's files left in stmhal/cmsis are all STM32 specific.
fccf110 to
8838f2f
Compare
8838f2f to
2ce201b
Compare
I thought about users that may want to use other parts of CMSIS - like the CMSIS-DSP library or CMSIS-RTX RTOS, for them the best place to put its source code would be lib/cmis/{dsp|rtx}. Especially DSP library is interesting with its target optimized math/control/statistics functions. If you would ever consider adding another part of CMSIS I think its better to add those extra 4 characters to the path now than to move all files when there will be need to. But its your call, I'll move them up if you wish. I've rebase the changes and also added a commit removing CMSIS-DSP headers which are currently unused. |
|
That's great, thank you. I left it as-is and merged, see b04d4a5 for the final commit. |
initial CLUE board defn
As per @dpgeorge's request from #2408.