8000 move generic CMSIS files to lib/cmsis by blazewicz · Pull Request #2441 · micropython/micropython · GitHub
[go: up one dir, main page]

Skip to content

move generic CMSIS files to lib/cmsis #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

blazewicz
Copy link
Contributor

As per @dpgeorge's request from #2408.

@dpgeorge
Copy link
Member

Is this the latest version of CMSIS? If we are going to upgrade, why not do it in one go: upgrade and move.

@blazewicz
Copy link
Contributor Author

I thought you may want to separate those two changes too have cleaner git log.

I've added second commit upgrading CMSIS headers to the newest version from ARM-software/CMSIS.

Also rebased on top of current HEAD.

@dpgeorge
Copy link
Member

I thought you may want to separate those two changes too have cleaner git log.

Yes, thanks, having the change log is better than not having it.

One last minor point: is there a reason to put the common cmsis files in lib/cmsis/inc instead of lib/cmsis?

Also, I removed the stm32f2xx cmsis files in 53bfcc9, so please rebase against that.

Files in lib/cmsis are generic for all Cortex-M MCU's
files left in stmhal/cmsis are all STM32 specific.
@blazewicz
Copy link
Contributor Author

One last minor point: is there a reason to put the common cmsis files in lib/cmsis/inc instead of lib/cmsis?

I thought about users that may want to use other parts of CMSIS - like the CMSIS-DSP library or CMSIS-RTX RTOS, for them the best place to put its source code would be lib/cmis/{dsp|rtx}.

Especially DSP library is interesting with its target optimized math/control/statistics functions.

If you would ever consider adding another part of CMSIS I think its better to add those extra 4 characters to the path now than to move all files when there will be need to.

But its your call, I'll move them up if you wish.

I've rebase the changes and also added a commit removing CMSIS-DSP headers which are currently unused.

@dpgeorge
Copy link
Member

That's great, thank you. I left it as-is and merged, see b04d4a5 for the final commit.

< 8DC4 input type="hidden" name="_method" value="put" autocomplete="off" />

@dpgeorge dpgeorge closed this Sep 30, 2016
@blazewicz blazewicz deleted the lib-cmsis branch February 28, 2017 17:21
tannewt pushed a commit to tannewt/circuitpython that referenced this pull request Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0